Added filtering capabilities #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great addition, thanks! Was thinking about adding the same thing as well 😊 Added a small comment you can have a look at. Would also like it that you update the readme and extend the example, so people know how to use it. |
|
I think we can close this 'cause the regex filter already covers this usecase :) |
|
I still see a valid purpose with this change, as it allows permanent exclusion of results that you might never wanna see. |
|
Mind resolving the conflicts @eliseomartelli? |
|
Can we get some examples of the regex if this isn't going to be merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love your search card so I thought that I may help by adding some domain-filtering capabilities :)