-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some jobs on Travis Trusty #187
Conversation
Surely this won’t work. Better to add something to the path?
Will _this_ work? 🤔
Will this override the Ember CLI one? 🤔
Adding an older |
Incidentally, Trusty has PhantomJS 2.0.0 installed, so we could perhaps abandon the Or should we switch to headless Chrome or Firefox? |
I have seen somewhere that Ember will swap PhantomJS for headless Chrome in version 16 but can find where I have seen that. So I think switching to headless Chrome is the future anyway. We could do that. See also: https://embermap.com/notes/59-ember-tests-with-headless-chrome |
It will be in ember-cli 15.0 See ember-cli/ember-cli#7148 |
ah, not too far away! Maybe it makes sense to just wait for that release and do it all at once. I have a preliminary PR on |
@backspace now your PR is merged do we wait for ember-cli 15.0 or can this be fixed now? |
I don’t think a new |
I assumed it was released also. Don't overwrite the version for this. We will wait. Perhaps fix this together with #110 |
This is unnecessary since Phantom is abandoned for tests.
A new version of What do you think, @broerse or interested parties? This grew beyond what I originally started the PR for, I can adjust as desired. |
Looking good @backspace ! I think no need to adjust this. But can you squash this so we I can see more clear what will be merged? |
GitHub lets you squash and merge from a PR now: So whatever you see on the Files changed tab is what the commit will look like. But if you want, I can still squash locally. |
I will take the change ;-) |
I'm affraid the changes to the ember-try config have removed the ember-data versions. I think ember-data still needs to be added to the ember-try setup like before: https://github.com/pouchdb-community/ember-pouch/pull/187/files#diff-d20f4baf61c4397c467d6218d0ba6a04L25 |
eep sorry about that, I can look into it tomorrow |
This is a pretty hackish solution to this problem, also discussed here:
ember-try
uses the presence of ayarn
command to determine whether toyarn install
. Something was going wrong with theyarn install
on theember-release
andember-beta
scenarios.This fixes those scenarios but then breaks the ones before them, the inverse of what was happening!
I’m going to ask over on the
ember-try
thread about whether it’s possible to bypass Yarn more elegantly. I’ll also see if I can override Ember CLI’s built-inember-try
version with an older one that doesn’t use Yarn.