-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: handle concurrent updates to newly created record & upgrade deps #246
Open
jacobq
wants to merge
15
commits into
pouchdb-community:master
Choose a base branch
from
jacobq:jrq-fork
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 11, 2019
-
fix: support multiple createRecord calls (fixes pouchdb-community#239)
This commit changes how ember-pouch implements `Adapter.createRecord`, which is invoked after calling `.save()` on a new record, so that it does not create multiple records if `.save()` is called more than once before the first operation has finished. If `.save()` is only invoked once before the record has finished persisting to the DB (i.e. the promise that it returns has resolved) then the behavior is unchanged. However, subsequent calls will wait for the previously returned promise to resolve and then, if changes have been made to the record, it will delegate the task to `updateRecord`. To avoid a problem caused by ember-data changing the ID associated with the internalModel/record when the record has finished persisting, the `Adapter.generateIdForRecord` method has been implemented so that it is available immediately. Previously ember-pouch had still been generating this id during `createRecord`, but ember-data was not being made aware of this until its returned promise resolved. Finally, rather than rely on `adapter.db.rel.uuid()` to generate an RFC4122 v4 UUID (requiring initialization to have completed), this has been replaced by the equivalent `uuid` module from npm, and the ember-auto-import addon has been installed to make it easy to access this from within ember-pouch.
Configuration menu - View commit details
-
Copy full SHA for 881c84b - Browse repository at this point
Copy the full SHA 881c84bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dea8126 - Browse repository at this point
Copy the full SHA dea8126View commit details -
BREAKING CHANGE: drop support for NodeJS versions prior to 8.0.0
Configuration menu - View commit details
-
Copy full SHA for 7bf44ad - Browse repository at this point
Copy the full SHA 7bf44adView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb4b66b - Browse repository at this point
Copy the full SHA eb4b66bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e522f73 - Browse repository at this point
Copy the full SHA e522f73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f9b316 - Browse repository at this point
Copy the full SHA 7f9b316View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d869b - Browse repository at this point
Copy the full SHA f8d869bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8506a29 - Browse repository at this point
Copy the full SHA 8506a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70993fc - Browse repository at this point
Copy the full SHA 70993fcView commit details -
Some of the changes introduced while updating ember / ember-cli, resulted in test failures resembling the problem described at the URL below: emberjs/ember-qunit#309
Configuration menu - View commit details
-
Copy full SHA for 931b42f - Browse repository at this point
Copy the full SHA 931b42fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6fe0b7 - Browse repository at this point
Copy the full SHA a6fe0b7View commit details -
test: fix store.unloadAll race condition in tests
The test labeled "creating an associated record stores a reference to it in the parent" was failing intermittently when run with other tests under conditions "dont save hasMany" and "sync". This problem appears to be caused by the test logic not waiting for `store.unloadAll()` to complete. The Ember Data API docs state that this function schedules its work to be done during the next run loop. However, instead of adding a delay and making assumptions about this, we wrap calls to this function in `run` to ensure that it has finished before continuing. See also: * https://api.emberjs.com/ember-data/3.14/classes/Store/methods/unloadAll?anchor=unloadAll * pouchdb-community#242 * pouchdb-community#243
Configuration menu - View commit details
-
Copy full SHA for 7d12ebc - Browse repository at this point
Copy the full SHA 7d12ebcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76efda9 - Browse repository at this point
Copy the full SHA 76efda9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52b80c3 - Browse repository at this point
Copy the full SHA 52b80c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a966968 - Browse repository at this point
Copy the full SHA a966968View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.