WIP: feat: handle concurrent updates to newly created record & upgrade deps #246
Commits on Nov 11, 2019
-
fix: support multiple createRecord calls (fixes pouchdb-community#239)
This commit changes how ember-pouch implements `Adapter.createRecord`, which is invoked after calling `.save()` on a new record, so that it does not create multiple records if `.save()` is called more than once before the first operation has finished. If `.save()` is only invoked once before the record has finished persisting to the DB (i.e. the promise that it returns has resolved) then the behavior is unchanged. However, subsequent calls will wait for the previously returned promise to resolve and then, if changes have been made to the record, it will delegate the task to `updateRecord`. To avoid a problem caused by ember-data changing the ID associated with the internalModel/record when the record has finished persisting, the `Adapter.generateIdForRecord` method has been implemented so that it is available immediately. Previously ember-pouch had still been generating this id during `createRecord`, but ember-data was not being made aware of this until its returned promise resolved. Finally, rather than rely on `adapter.db.rel.uuid()` to generate an RFC4122 v4 UUID (requiring initialization to have completed), this has been replaced by the equivalent `uuid` module from npm, and the ember-auto-import addon has been installed to make it easy to access this from within ember-pouch.
-
-
BREAKING CHANGE: drop support for NodeJS versions prior to 8.0.0
-
-
-
-
-
-
-
Some of the changes introduced while updating ember / ember-cli, resulted in test failures resembling the problem described at the URL below: emberjs/ember-qunit#309
-
-
test: fix store.unloadAll race condition in tests
The test labeled "creating an associated record stores a reference to it in the parent" was failing intermittently when run with other tests under conditions "dont save hasMany" and "sync". This problem appears to be caused by the test logic not waiting for `store.unloadAll()` to complete. The Ember Data API docs state that this function schedules its work to be done during the next run loop. However, instead of adding a delay and making assumptions about this, we wrap calls to this function in `run` to ensure that it has finished before continuing. See also: * https://api.emberjs.com/ember-data/3.14/classes/Store/methods/unloadAll?anchor=unloadAll * pouchdb-community#242 * pouchdb-community#243
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.