(#170) Move to pouchdb-utils #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes useless returns in three of the API methods as they were used to call callback in the end. Those would break with PouchDB's toPromise as it would enforce fulfilling them.
|
As @nolanlawson acknowledged that part in his review of the previous PR (cf. #171), I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #171 (again...).
I finally let down the commit about
__interopDefaultas it has more to do with #176 than this PR.This PR moves current code to use the
toPromiseprovided bypouchdb-utils.It also makes some clean in the other utility functions to also make use of
pouchdb-utils.(TypeError: Promise is not a constructor #170) Use pouchdb-utils module for toPromise and once
This also removes useless returns in three of the API methods as they
were used to call callback in the end. Those would break with PouchDB's
toPromise as it would enforce fulfilling them.
(TypeError: Promise is not a constructor #170) Use pouchdb-utils module for clone and uuid
(TypeError: Promise is not a constructor #170) Use pouchdb-utils' assign in place of pouchdb-extend
Also bumps to PouchDB 6.1.1
(TypeError: Promise is not a constructor #170) Clean sub-module utils