(#150) Replace base URL regex with url-parse #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitjes
requested changes
Nov 15, 2017
There was a problem hiding this comment.
LGTM.
Would you mind adding unit tests for those along the lines "Create a remote DB with a url and check that getUsersUrl(db) is correct (two cases: with/without trailing slash), create a local DB with a simple name and check that getUsersUrl(db) is correct" ?
Also, I'm starting using angular-style commit style to use standard-version for release versioning and changelog generation. That would need to rename your commit "fix(urls): replace base URL regex with url-parse". (The "Closes ..." will be used as well by the changelog generator.)
|
@tlvince Also can you rebase please ? If you don't have time to rebase and add tests, tell me and I will do it. |
|
Merged in 7472135. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements #160.
Closes #150.
Closes #160.