Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rated s parameter in generator dataframe #634

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

EtienneLt
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
#631

Signed-off-by: Etienne LESOT <[email protected]>
@geofjamg
Copy link
Member

Don't forget to update the PR on core repo with moved data frame code

@EtienneLt
Copy link
Contributor Author

Don't forget to update the PR on core repo with moved data frame code

yes I forgot

@EtienneLt EtienneLt merged commit 0458ce1 into main Jul 21, 2023
7 checks passed
@EtienneLt EtienneLt deleted the add-rated-s-parameter-for-generators branch July 21, 2023 06:23
obrix pushed a commit that referenced this pull request Jul 21, 2023
* add rated s parameter in generator dataframe

Signed-off-by: Etienne LESOT <[email protected]>
geofjamg pushed a commit that referenced this pull request Aug 16, 2023
* add rated s parameter in generator dataframe

Signed-off-by: Etienne LESOT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants