Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated attributes in network modification functions #732

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

colinepiloquet
Copy link
Member

@colinepiloquet colinepiloquet commented Apr 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@EtienneLt EtienneLt force-pushed the remove_deprecated_attributes_network_modifications branch from 79cd790 to 604eaab Compare May 23, 2024 14:05
@EtienneLt EtienneLt force-pushed the remove_deprecated_attributes_network_modifications branch from 604eaab to f9f8ccf Compare June 26, 2024 08:13
@EtienneLt EtienneLt merged commit d290d9a into main Jun 26, 2024
6 checks passed
@EtienneLt EtienneLt deleted the remove_deprecated_attributes_network_modifications branch June 26, 2024 08:45
geofjamg pushed a commit that referenced this pull request Jun 26, 2024
unetablettedechocolat pushed a commit that referenced this pull request Jun 26, 2024
geofjamg pushed a commit that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants