Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right clicking osu! icon on Windows taskbar doesn't open context menu #17965

Closed
Joehuu opened this issue Apr 24, 2022 · 3 comments · Fixed by #17972
Closed

Right clicking osu! icon on Windows taskbar doesn't open context menu #17965

Joehuu opened this issue Apr 24, 2022 · 3 comments · Fixed by #17972
Assignees
@peppy
Labels
area:installer platform/windows

Comments

@Joehuu
Copy link
Member

Joehuu commented Apr 24, 2022 •
edited
Loading

Type

Other

Bug description

Noticed when trying to reproduce #10588.

This is only reproducible in release builds, and seems like Windows 8.1 is unaffected (only 10/11).

Note that this can sometimes break right clicking on any other icon, and the only fix is restarting windows explorer.

Screenshots or videos

2022-04-24_11-25-36

Version

Since 2022.314.0 (Clowd.Squirrel)

Logs

N/A
@Joehuu
Copy link
Member Author

Joehuu commented Apr 24, 2022

Didn't notice I duplicated #17963 (because it specifies tournament, but can be reproduced anywhere), closing.

@Joehuu Joehuu closed this as completed Apr 24, 2022
@bdach
Copy link
Collaborator

bdach commented Apr 24, 2022

I dunno about that, that other issue mentions something about resolution? Is that just misguided/wrong? Too far from a windows box to check myself right now.

@Joehuu
Copy link
Member Author

Joehuu commented Apr 24, 2022

Yeah, seems wrong, but I wanted to keep the older issue. Can reopen this if the description is better.

Can be even reproduced with lazer closed and just pinned on the taskbar.

@frenzibyte frenzibyte mentioned this issue Apr 24, 2022
Closed
@peppy peppy reopened this Apr 25, 2022
@peppy peppy self-assigned this Apr 25, 2022
peppy added a commit to peppy/osu that referenced this issue Apr 25, 2022
@peppy
Fix windows taskbar context menu not popping up correctly
7e9d51f 
Closes ppy#17965.

Note that this will cause a second osu! icon to appear after running the
application (after any update). As per the inline comment, this will
eventually be resolved via clowd/Clowd.Squirrel#24.

I do think having context menus working is more important than duplicate
icons.

Note that for anyone who already has a pinned taskbar icon, it will need
to be manually unpinned and repinned after a future update to actually
fix this issue.

Thanks to @caesay for help with investigation.
@peppy peppy mentioned this issue Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
area:installer platform/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix windows taskbar context menu not popping up correctly peppy/osu
3 participants
@peppy @bdach @Joehuu