Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug play downloaded file if there #81

Merged
merged 22 commits into from
Apr 25, 2020
Merged

Bug play downloaded file if there #81

merged 22 commits into from
Apr 25, 2020

Conversation

pravinyo
Copy link
Owner

Resolves #75

It also has few minor fixes for connection toast
It has now support for offline media playing and online.
It smartly checks for offline media and create playlist which saves user bandwidth

@pravinyo
Context changed to Activity
9aa5ecc
@pravinyo
getter and setter added for downloads folder path
d092a43
@pravinyo
key added for downloads folder path in sharedPref
8bbbac6
@pravinyo
album subpath is set to be it's id for easy and unique reference
ee04740
@pravinyo
context changed to Activity and root folder is fetched from sharedPref
2f3ee1e
@pravinyo
hard coded parent directory is provided by function param
cf58a49
@pravinyo
context changed to application
38aa7b9
@pravinyo
download path string resource added
694e064
@pravinyo
unused adapter removed
35a5fc8
@pravinyo
context changed to application
3d63b24
@pravinyo
logging added for else
3be7132
@pravinyo
unused imports removed
9178dd0
@pravinyo
removed bookId param as it us not used
192e7a6
@pravinyo
player code is moved to AudioBookPlayer.kt class
7899f9a
@pravinyo
AudioPlayer code is segregated from Services
b979a07
@pravinyo
MediaSource creation is segregated from Service for Player
50e9092
@pravinyo
todos removed
aadade4
@pravinyo
legacy external storage support enabled
2aa200b
@pravinyo
LocalFilesForBook.kt added to parse local and online files together
f45ac40
@pravinyo
local file playing support added
9cdfb67
@pravinyo
modified to emit event
3ddd4c6
@pravinyo
implementation changed as per new modification of connectionLD
e3f083b
@pravinyo pravinyo added the bug Something isn't working label Apr 25, 2020
@pravinyo pravinyo added this to the bug fixes milestone Apr 25, 2020
@pravinyo pravinyo self-assigned this Apr 25, 2020
@github-actions github-actions bot added app issues related to app working feature Feature related issue library issues related to core library labels Apr 25, 2020
@pravinyo pravinyo merged commit cefcf21 into development Apr 25, 2020
@pravinyo pravinyo deleted the bug_play_downloaded_file_if_there branch April 25, 2020 14:35
@github-actions
Copy link

github-actions bot commented May 6, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pravinyo pravinyo

Labels
app issues related to app working bug Something isn't working feature Feature related issue library issues related to core library
Projects
None yet
Milestone
bug fixes
Development

Successfully merging this pull request may close these issues.
1 participant
@pravinyo