Fix react-spring error caused by augmented function contexts #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React-spring provides its own [custom context wrapper](https://github.com/pmndrs/react-spring/blob/d5d8271656f3f3c464a47ad9d39941250ce588b6/packages/core/src/SpringContext.tsx#L33), which effectively does `Object.assign(function SpringContext, createContext(defaultValue))`. This breaks `preact/hooks` because it causes the hook state for `useContext()` to have a `.__c` property that contains a `function`. We mangle both `_cleanup` and `_context` to `__c`, which collides. Normally this is not an issue because `createContext()` returns an Object.
|
Uh it was a headscratcher. Also reported previously by somebody else pmndrs/react-spring#1508 |
developit
added a commit
to preactjs/preact-devtools
that referenced
this pull request
May 25, 2021
This updates the `useContext()` hook state property (`_context`) to reflect it being renamed to `c` in preactjs/preact#3165.
marvinhagemeister
approved these changes
May 25, 2021
marvinhagemeister
added a commit
to preactjs/preact-devtools
that referenced
this pull request
May 25, 2021
Update useContext() hook state property for preactjs/preact#3165
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React-spring provides its own custom context wrapper, which effectively does
Object.assign(function SpringContext, createContext(defaultValue)). This breakspreact/hooksbecause it causes the hook state foruseContext()to have a.__cproperty that contains afunction. We mangle both_cleanupand_contextto__c, which collides. Normally this is not an issue becausecreateContext()returns an Object.