Skip to content

Commit

Permalink
Conversant Bid Adapter: clean up response
Browse files Browse the repository at this point in the history
  • Loading branch information
johwier committed Jun 13, 2024
1 parent 03a7d1e commit 9945b9a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 44 deletions.
2 changes: 1 addition & 1 deletion modules/conversantBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const converter = ortbConverter({
},
response(buildResponse, bidResponses, ortbResponse, context) {
const response = buildResponse(bidResponses, ortbResponse, context);
return response.bids;
return response;
},
overrides: {
imp: {
Expand Down
44 changes: 1 addition & 43 deletions test/spec/modules/conversantBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ describe('Conversant adapter tests', function() {

before(() => {
request = spec.buildRequests(bidRequests, {});
response = spec.interpretResponse(bidResponses, request);
response = spec.interpretResponse(bidResponses, request).bids;
});

it('Banner', function() {
Expand Down Expand Up @@ -519,48 +519,6 @@ describe('Conversant adapter tests', function() {
}
});

it('Paapi', function() {
const paapi = [
{
impid: 'bid000',
igs: [
{
config: {
seller: 'https://paapi.ad.cpe.dotomi.com',
decisionLogicURL: 'https://paapi.ad.cpe.dotomi.com/js/decision-logic-component-seller.js',
interestGroupBuyers: [ 'https://cookieless-campaign.lab-00.retargetly.com' ],
perBuyerSignals: {
'https://cookieless-campaign.lab-00.retargetly.com': { 'tid': '123456789012341234' }
},
sellerSignals: {
networkRequestId: '717847096745883980',
transactionId: '717847096745883981',
siteId: '207693',
tid: 5,
supplyTypeId: 1,
partnerId: 'Prebid.js',
partnerVersion: '1.2.3',
placementId: '10145350'
}
}
}
]
}];
const request = spec.buildRequests([bidRequests[0]], {});
let bidResponse = JSON.parse(JSON.stringify(bidResponses));
bidResponse.body.seatbid[0].bid = [bidResponses.body.seatbid[0].bid[0]];
deepSetValue(bidResponse, 'body.ext.igi', paapi);

const response = spec.interpretResponse(bidResponse, request);
const bid = response.bids[0];

expect(bid).to.have.property('requestId', 'bid000');
expect(response).to.have.property('paapiAuctionConfigs');
const paapiResponse = response.paapiAuctionConfigs[0];
expect(paapiResponse).to.have.property('bidId', paapi[0].impid);
expect(paapiResponse.config).to.deep.equal(paapi[0].igs[0].config);
});

it('Verify publisher commond id support', function() {
// clone bidRequests
let requests = utils.deepClone(bidRequests);
Expand Down

0 comments on commit 9945b9a

Please sign in to comment.