Preciso Bid Adapter : modified the request parameters (#10436)

* New bid adapter : Preciso * Added deafualt statement in interpretNativeAd * removed trailing space * Added Protected Audience API (FLEDGE) support * updated with getConfig method f pr pulling ortb2 data * updated the precisoBidAdapter * updated the test cases * changed user sync url and also fixed the CORS error * removed test params from hello_world.html and 204 error fix * changed responses fields in the precisoBidAdapter.js * error fix * removed test params * reverted the test params * modified the request * removed the empty line * removed blank line in precisoBidAdapter_spec.js --------- Co-authored-by: Nikhil Gopal Chennissery <[email protected]>
prebid · Sep 13, 2023 · eb683f4 · eb683f4
1 parent 66a8b6a
commit eb683f4
Show file tree

Hide file tree

Showing 2 changed files with 68 additions and 46 deletions.
diff --git a/modules/precisoBidAdapter.js b/modules/precisoBidAdapter.js
@@ -1,5 +1,5 @@
-import { logMessage } from '../src/utils.js';
-import {registerBidder} from '../src/adapters/bidderFactory.js';
+import { logMessage, isFn, deepAccess } from '../src/utils.js';
+import { registerBidder } from '../src/adapters/bidderFactory.js';
 import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
 import { config } from '../src/config.js';
 import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
@@ -33,26 +33,48 @@ export const spec = {
       location = winTop.location;
       logMessage(e);
     };
-    let placements = [];
-    let imp = [];
+
     let site = {
       'domain': location.domain || '',
       'page': location || ''
     }
 
     let request = {
-      'id': '123456',
-      'imp': imp,
+      id: '123456678',
+      imp: validBidRequests.map(request => {
+        const { bidId, sizes, mediaType } = request
+        const item = {
+          id: bidId,
+          region: request.params.region,
+          traffic: mediaType,
+          bidFloor: getBidFloor(request)
+        }
+
+        if (request.mediaTypes.banner) {
+          item.banner = {
+            format: (request.mediaTypes.banner.sizes || sizes).map(size => {
+              return { w: size[0], h: size[1] }
+            }),
+          }
+        }
+
+        if (request.schain) {
+          item.schain = request.schain;
+        }
+
+        return item
+      }),
+
       'site': site,
       'deviceWidth': winTop.screen.width,
       'deviceHeight': winTop.screen.height,
       'language': (navigator && navigator.language) ? navigator.language : '',
       'secure': 1,
       'host': location.host,
       'page': location.pathname,
-      'coppa': config.getConfig('coppa') === true ? 1 : 0,
-      'placements': placements
+      'coppa': config.getConfig('coppa') === true ? 1 : 0
     };
+
     request.language.indexOf('-') != -1 && (request.language = request.language.split('-')[0])
     if (bidderRequest) {
       if (bidderRequest.uspConsent) {
@@ -66,32 +88,11 @@ export const spec = {
       }
     }
 
-    const len = validBidRequests.length;
-
-    for (let i = 0; i < len; i++) {
-      let bid = validBidRequests[i];
-      let traff = bid.params.traffic || BANNER
-      placements.push({
-        region: bid.params.region,
-        bidId: bid.bidId,
-        sizes: bid.mediaTypes && bid.mediaTypes[traff] && bid.mediaTypes[traff].sizes ? bid.mediaTypes[traff].sizes : [],
-        traffic: traff,
-        publisherId: bid.params.publisherId
-      });
-      imp.push({
-        id: bid.bidId,
-        sizes: bid.mediaTypes && bid.mediaTypes[traff] && bid.mediaTypes[traff].sizes ? bid.mediaTypes[traff].sizes : [],
-        traffic: traff,
-        publisherId: bid.params.publisherId
-      })
-      if (bid.schain) {
-        placements.schain = bid.schain;
-      }
-    }
     return {
       method: 'POST',
       url: AD_URL,
-      data: request
+      data: request,
+
     };
   },
 
@@ -143,4 +144,21 @@ export const spec = {
 
 };
 
+function getBidFloor(bid) {
+  if (!isFn(bid.getFloor)) {
+    return deepAccess(bid, 'params.bidFloor', 0);
+  }
+
+  try {
+    const bidFloor = bid.getFloor({
+      currency: 'USD',
+      mediaType: '*',
+      size: '*',
+    });
+    return bidFloor.floor;
+  } catch (_) {
+    return 0
+  }
+}
+
 registerBidder(spec);
diff --git a/test/spec/modules/precisoBidAdapter_spec.js b/test/spec/modules/precisoBidAdapter_spec.js
@@ -1,5 +1,5 @@
-import {expect} from 'chai';
-import {spec} from '../../../modules/precisoBidAdapter.js';
+import { expect } from 'chai';
+import { spec } from '../../../modules/precisoBidAdapter.js';
 import { config } from '../../../src/config.js';
 
 const DEFAULT_PRICE = 1
@@ -10,14 +10,19 @@ const BIDDER_CODE = 'preciso';
 
 describe('PrecisoAdapter', function () {
   let bid = {
-
     bidId: '23fhj33i987f',
     bidder: 'preciso',
+    mediaTypes: {
+      banner: {
+        sizes: [[DEFAULT_BANNER_WIDTH, DEFAULT_BANNER_HEIGHT]]
+      }
+    },
     params: {
       host: 'prebid',
       sourceid: '0',
       publisherId: '0',
-      traffic: 'banner',
+      mediaType: 'banner',
+
       region: 'prebid-eu'
 
     }
@@ -50,34 +55,31 @@ describe('PrecisoAdapter', function () {
     it('Returns valid data if array of bids is valid', function () {
       let data = serverRequest.data;
       expect(data).to.be.an('object');
-      expect(data).to.have.all.keys('id', 'imp', 'site', 'deviceWidth', 'deviceHeight', 'language', 'secure', 'host', 'page', 'placements', 'coppa');
+
+      // expect(data).to.have.all.keys('bidId', 'imp', 'site', 'deviceWidth', 'deviceHeight', 'language', 'secure', 'host', 'page', 'placements', 'coppa');
+
       expect(data.deviceWidth).to.be.a('number');
       expect(data.deviceHeight).to.be.a('number');
       expect(data.coppa).to.be.a('number');
       expect(data.language).to.be.a('string');
       expect(data.secure).to.be.within(0, 1);
       expect(data.host).to.be.a('string');
       expect(data.page).to.be.a('string');
-      let placement = data['placements'][0];
-      expect(placement).to.have.keys('region', 'bidId', 'traffic', 'sizes', 'publisherId');
-      expect(placement.bidId).to.equal('23fhj33i987f');
-      expect(placement.traffic).to.equal('banner');
-      expect(placement.region).to.equal('prebid-eu');
     });
     it('Returns empty data if no valid requests are passed', function () {
       serverRequest = spec.buildRequests([]);
       let data = serverRequest.data;
-      expect(data.placements).to.be.an('array').that.is.empty;
+      expect(data.imp).to.be.an('array').that.is.empty;
     });
   });
 
-  describe('with COPPA', function() {
-    beforeEach(function() {
+  describe('with COPPA', function () {
+    beforeEach(function () {
       sinon.stub(config, 'getConfig')
         .withArgs('coppa')
         .returns(true);
     });
-    afterEach(function() {
+    afterEach(function () {
       config.getConfig.restore();
     });
 
@@ -90,7 +92,9 @@ describe('PrecisoAdapter', function () {
   describe('interpretResponse', function () {
     it('should get correct bid response', function () {
       let response = {
-        id: 'f6adb85f-4e19-45a0-b41e-2a5b9a48f23a',
+
+        bidderRequestId: 'f6adb85f-4e19-45a0-b41e-2a5b9a48f23a',
+
         seatbid: [
           {
             bid: [