-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bid Adapters, GPID ,and PBAdSlot #10187
Comments
PMC: in agreement that we need to move away from pbAdslot. We'll start with outreach to these bidders to make the change. |
Re-check the list to verify who needs to be contacted. |
'ortb2Imp.ext.gpid' should be honored as some publishers might be configuring it directly according to the community extension |
@ChrisHuie Hello, as Onetag within the "9.0 fixes" Excel sheet, this issue has been marked as a fix to be implemented for version 9 of Prebid.js. However, the logic indicated above is already present within our adapter:
Could you confirm that no further interventions are necessary? Thank you. |
I completed all remaining in #11660 None of these had the concern they were getting them both and treating them independently. |
Type of issue
using incorrect data
Description
A number of bid adapters are setting the 'GPID' with the value of 'pbAdSlot'. This isn't correct. The background material on this highlights that pbAdSlot pre-dated the TradeDesk's efforts to standardize the GPID.
It's true that the values may be the same, but publishers currently have to set both because the following bid adapters use them interchangeably.
Prebid would like to see all of these bid adapters change their logic so that GPID is set first from GPID, then from pbadslot as a backup. The plan is to eventually drop pbAdSlot entirely.
i.e. instead of
The adapters should do something like
Bidders
Separately -
The text was updated successfully, but these errors were encountered: