Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bid Adapters, GPID ,and PBAdSlot #10187

Closed
12 of 19 tasks
bretg opened this issue Jul 6, 2023 · 5 comments · Fixed by #11660
Closed
12 of 19 tasks

Bid Adapters, GPID ,and PBAdSlot #10187

bretg opened this issue Jul 6, 2023 · 5 comments · Fixed by #11660
Assignees

Comments

@bretg
Copy link
Collaborator

bretg commented Jul 6, 2023

Type of issue

using incorrect data

Description

A number of bid adapters are setting the 'GPID' with the value of 'pbAdSlot'. This isn't correct. The background material on this highlights that pbAdSlot pre-dated the TradeDesk's efforts to standardize the GPID.

It's true that the values may be the same, but publishers currently have to set both because the following bid adapters use them interchangeably.

Prebid would like to see all of these bid adapters change their logic so that GPID is set first from GPID, then from pbadslot as a backup. The plan is to eventually drop pbAdSlot entirely.

i.e. instead of

  let gpid = deepAccess(bid, 'ortb2Imp.ext.data.pbadslot');

The adapters should do something like

   let gpid = deepAccess(bid, 'ortb2Imp.ext.gpid') || deepAccess(bid, 'ortb2Imp.ext.data.pbadslot');

Bidders

  • appnexus
  • cadentApertureMX
  • colossusssp
  • goldbach
  • grid
  • gumgum
  • kueezRtb
  • mediafuse
  • minutemediaplus
  • onetag
  • pixfuture
  • richaudience
  • sharethrough
  • smartadserver
  • sonobi
  • vidazoo
  • winr
  • yieldmo

Separately -

  • luponmedia is referring to fpd.context.pbAdSlot. fpd.context has been discontinued.
@lcorrigall
Copy link

PMC: in agreement that we need to move away from pbAdslot. We'll start with outreach to these bidders to make the change.

@lcorrigall
Copy link

Re-check the list to verify who needs to be contacted.

@patmmccann
Copy link
Collaborator

'ortb2Imp.ext.gpid' should be honored as some publishers might be configuring it directly according to the community extension

@fliccione
Copy link
Contributor

fliccione commented May 15, 2024

@ChrisHuie Hello, as Onetag within the "9.0 fixes" Excel sheet, this issue has been marked as a fix to be implemented for version 9 of Prebid.js. However, the logic indicated above is already present within our adapter:

this['gpid'] = deepAccess(bidRequest, 'ortb2Imp.ext.gpid') || deepAccess(bidRequest, 'ortb2Imp.ext.data.pbadslot');

Could you confirm that no further interventions are necessary? Thank you.

@patmmccann
Copy link
Collaborator

I completed all remaining in #11660

None of these had the concern they were getting them both and treating them independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants