Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getConfig cleanup of consent management #10658

Closed
patmmccann opened this issue Oct 30, 2023 · 5 comments · Fixed by #11592
Closed

getConfig cleanup of consent management #10658

patmmccann opened this issue Oct 30, 2023 · 5 comments · Fixed by #11592
Labels
9.0 API Change bug

Comments

@patmmccann
Copy link
Collaborator

This is a serious bug in several adapters. Consent management needs to come off the request.

Prebid.js/modules/aidemBidAdapter.js

Line 111 in 56292c4

const consentManagement = config.getConfig('consentManagement');

Prebid.js/modules/apstreamBidAdapter.js

Line 295 in 56292c4

let isIab = config.getConfig('consentManagement.cmpApi') != 'static';

Prebid.js/modules/sirdataRtdProvider.js

Line 85 in 56292c4

} else if (config.getConfig('consentManagement.gdpr')) {

Prebid.js/modules/madvertiseBidAdapter.js

Line 56 in 56292c4

src = src + '&gdpr=' + (bidderRequest.gdprConsent.gdprApplies ? '1' : '0') + '&consent[0][format]=' + config.getConfig('consentManagement.cmpApi') + '&consent[0][value]=' + bidderRequest.gdprConsent.consentString;

@patmmccann patmmccann added the bug label Oct 30, 2023
@ausgomez ausgomez mentioned this issue Oct 31, 2023
Closed
4 tasks
@patmmccann
Copy link
Collaborator Author

@RemiSirdata @gsollazzo @darkstarac please take a look

@darkstarac
Copy link
Contributor

@patmmccann Hello Patrick. Sorry to bother you, but it's not very clear to us what fix is needed. Have you got some suggestions on this issue ?

@darkstarac
Copy link
Contributor

@patmmccann Hello Patrick ? Any hint on this issue ? As asked before we some clarification about the problem.

@nouchy nouchy mentioned this issue May 20, 2024
Merged
5 tasks
@patmmccann
Copy link
Collaborator Author

@darkstarac consent should not come from a getConfig call. You should only need to access the request object

@nouchy
Copy link
Contributor

nouchy commented May 22, 2024 •
edited
Loading

This is a serious bug in several adapters. Consent management needs to come off the request.

Prebid.js/modules/aidemBidAdapter.js

Line 111 in 56292c4

const consentManagement = config.getConfig('consentManagement');

Prebid.js/modules/apstreamBidAdapter.js

Line 295 in 56292c4

let isIab = config.getConfig('consentManagement.cmpApi') != 'static';

Prebid.js/modules/sirdataRtdProvider.js

Line 85 in 56292c4

} else if (config.getConfig('consentManagement.gdpr')) {

Prebid.js/modules/madvertiseBidAdapter.js

Line 56 in 56292c4

src = src + '&gdpr=' + (bidderRequest.gdprConsent.gdprApplies ? '1' : '0') + '&consent[0][format]=' + config.getConfig('consentManagement.cmpApi') + '&consent[0][value]=' + bidderRequest.gdprConsent.consentString;

This has been fix sor sirdata RTD Module, please see #11524. Thanks !

Wazabit added a commit to AIDEM-Technologies/Prebid.js that referenced this issue May 27, 2024
@Wazabit
Fixed getConfig cleanup of consent management (Issue prebid#10658)
a740a11
@Wazabit Wazabit mentioned this issue May 28, 2024
Merged
1 task
Wazabit added a commit to AIDEM-Technologies/Prebid.js that referenced this issue May 28, 2024
@Wazabit
Fixed getConfig cleanup of consent management (Issue prebid#10658)
4dc9159
Wazabit added a commit to AIDEM-Technologies/Prebid.js that referenced this issue May 28, 2024
@Wazabit
Fixed getConfig cleanup of consent management (Issue prebid#10658)
fed53f6
Wazabit added a commit to AIDEM-Technologies/Prebid.js that referenced this issue May 28, 2024
@Wazabit
Fixed getConfig cleanup of consent management (Issue prebid#10658)
8815373
ChrisHuie pushed a commit that referenced this issue May 28, 2024
@Wazabit @gsollazzo @darkstarac
AIDEM Bid Adapter : fixed getConfig cleanup of consent management (#1…
b44deb8 
…1575)

* AIDEM Bid Adapter

* Added _spec.js

* update

* Fix Navigator in _spec.js

* Removed timeout handler.

* Added publisherId as required bidder params

* moved publisherId into site publisher object

* Added wpar to environment

* Added placementId parameter

* added unit tests for the wpar environment object

* PlacementId is now a required parameter
Added optional rateLimit parameter
Added publisherId, siteId, placementId in win notice payload
Added unit tests

* Revert to optional placementId parameter
Added missing semicolons

* Extended win notice

* Added arbitrary ext field to win notice

* Moved aidemBidAdapter implementation to comply with ortbConverter

* disabled video-specific tests

* Fixed getConfig cleanup of consent management (Issue #10658)

* Fixed getConfig cleanup of consent management (Issue #10658)

* Fixed getConfig cleanup of consent management (Issue #10658)

* Fixed getConfig cleanup of consent management (Issue #10658)

---------

Co-authored-by: Giovanni Sollazzo <[email protected]>
Co-authored-by: darkstar <[email protected]>
Co-authored-by: AndreaC <[email protected]>
@patmmccann patmmccann mentioned this issue May 28, 2024
Merged
patmmccann pushed a commit that referenced this issue Jul 17, 2024
@Wazabit @gsollazzo @darkstarac
AIDEM Bid Adapter: Added gvlid param for Europe GDPR compliance (#11987)
b561a15 
* AIDEM Bid Adapter

* Added _spec.js

* update

* Fix Navigator in _spec.js

* Removed timeout handler.

* Added publisherId as required bidder params

* moved publisherId into site publisher object

* Added wpar to environment

* Added placementId parameter

* added unit tests for the wpar environment object

* PlacementId is now a required parameter
Added optional rateLimit parameter
Added publisherId, siteId, placementId in win notice payload
Added unit tests

* Revert to optional placementId parameter
Added missing semicolons

* Extended win notice

* Added arbitrary ext field to win notice

* Moved aidemBidAdapter implementation to comply with ortbConverter

* disabled video-specific tests

* Fixed getConfig cleanup of consent management (Issue #10658)

* Fixed getConfig cleanup of consent management (Issue #10658)

* Fixed getConfig cleanup of consent management (Issue #10658)

* Fixed getConfig cleanup of consent management (Issue #10658)

* Added gvlid param for Europe GDPR compliance

---------

Co-authored-by: Giovanni Sollazzo <[email protected]>
Co-authored-by: darkstar <[email protected]>
Co-authored-by: AndreaC <[email protected]>
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this issue Jul 18, 2024
@Wazabit @gsollazzo
@darkstarac @DecayConstant
AIDEM Bid Adapter : fixed getConfig cleanup of consent management (pr…
5588cd0 
…ebid#11575)

* AIDEM Bid Adapter

* Added _spec.js

* update

* Fix Navigator in _spec.js

* Removed timeout handler.

* Added publisherId as required bidder params

* moved publisherId into site publisher object

* Added wpar to environment

* Added placementId parameter

* added unit tests for the wpar environment object

* PlacementId is now a required parameter
Added optional rateLimit parameter
Added publisherId, siteId, placementId in win notice payload
Added unit tests

* Revert to optional placementId parameter
Added missing semicolons

* Extended win notice

* Added arbitrary ext field to win notice

* Moved aidemBidAdapter implementation to comply with ortbConverter

* disabled video-specific tests

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

---------

Co-authored-by: Giovanni Sollazzo <[email protected]>
Co-authored-by: darkstar <[email protected]>
Co-authored-by: AndreaC <[email protected]>
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this issue Jul 18, 2024
@Wazabit @gsollazzo
@darkstarac @DecayConstant
AIDEM Bid Adapter: Added gvlid param for Europe GDPR compliance (preb…
df0e87b 
…id#11987)

* AIDEM Bid Adapter

* Added _spec.js

* update

* Fix Navigator in _spec.js

* Removed timeout handler.

* Added publisherId as required bidder params

* moved publisherId into site publisher object

* Added wpar to environment

* Added placementId parameter

* added unit tests for the wpar environment object

* PlacementId is now a required parameter
Added optional rateLimit parameter
Added publisherId, siteId, placementId in win notice payload
Added unit tests

* Revert to optional placementId parameter
Added missing semicolons

* Extended win notice

* Added arbitrary ext field to win notice

* Moved aidemBidAdapter implementation to comply with ortbConverter

* disabled video-specific tests

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Added gvlid param for Europe GDPR compliance

---------

Co-authored-by: Giovanni Sollazzo <[email protected]>
Co-authored-by: darkstar <[email protected]>
Co-authored-by: AndreaC <[email protected]>
mefjush pushed a commit to adhese/Prebid.js that referenced this issue Jul 19, 2024
@Wazabit @gsollazzo
@darkstarac @mefjush
AIDEM Bid Adapter: Added gvlid param for Europe GDPR compliance (preb…
4ea488b 
…id#11987)

* AIDEM Bid Adapter

* Added _spec.js

* update

* Fix Navigator in _spec.js

* Removed timeout handler.

* Added publisherId as required bidder params

* moved publisherId into site publisher object

* Added wpar to environment

* Added placementId parameter

* added unit tests for the wpar environment object

* PlacementId is now a required parameter
Added optional rateLimit parameter
Added publisherId, siteId, placementId in win notice payload
Added unit tests

* Revert to optional placementId parameter
Added missing semicolons

* Extended win notice

* Added arbitrary ext field to win notice

* Moved aidemBidAdapter implementation to comply with ortbConverter

* disabled video-specific tests

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Fixed getConfig cleanup of consent management (Issue prebid#10658)

* Added gvlid param for Europe GDPR compliance

---------

Co-authored-by: Giovanni Sollazzo <[email protected]>
Co-authored-by: darkstar <[email protected]>
Co-authored-by: AndreaC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.0 API Change bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prebid 9.0: fix consent getconfigs prebid/Prebid.js
3 participants
@patmmccann @nouchy @darkstarac