Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove bid adapter access to navigator #11001

Open
patmmccann opened this issue Jan 29, 2024 · 1 comment
Open

Proposal: remove bid adapter access to navigator #11001

patmmccann opened this issue Jan 29, 2024 · 1 comment

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jan 29, 2024

Type of issue

Proposal

Description

An enormous variety of code constructs device portion of bid requests by accessing navigator, typically in slightly varying ways, or worse, copy pasted between one adapter to the next.

function getLanguage() {

Core should be able to gather all the required information in navigator and construct the device object on the request. Banning access to navigator should make the project smaller, the code more maintainable, bid requests more uniform, and finally, if something is missing from core and someone needs to add it, that additional information will propagate to more integrations more quickly.

@patmmccann
Copy link
Collaborator Author

patmmccann commented May 7, 2024

cc @giuseppe-exads you just added a bunch of logic relying on navigator for the exads adapter. We'd prefer you rely on the request object and if you need any of the transformations you committed, you consider issuing a pull request to the request object formation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Req
Development

No branches or pull requests

2 participants