Discovery Bid Adapter : fix window.top bug #11511
Conversation
ChrisHuie
changed the title
|
@ChrisHuie Hi, sorry to bother you, could you please help me cr it? This submission is very important to us.❤️ |
modules/discoveryBidAdapter.js
Outdated
| export function getDM(win = window) { | ||
| let dm; | ||
| try { | ||
| dm = win.top.navigator.deviceMemory; |
There was a problem hiding this comment.
See #11001 ; please move these functions into a library in the fpd group of imports. I don't think we want them in everyone's device object by default though, as the primary purpose is fingerprinting, correct?
There was a problem hiding this comment.
I have modified it as required, please help me cr it again.
Thanks.
|
The code changes look good, but I am unable to checkout this pr and test. I think you need to rebase master. It doesn't make sense to me why, these changes shouldn't conflict, but I don't want to try to rebase or change anything on my end to get this working. |
|
@Rothalack I understand. I will modify and submit immediately |
There was a problem hiding this comment.
I still had to manually check this out into a new branch for myself to test. Everything is working in testing. I still don't know why github complains about this when I try to gh pr checkout. I think it's because there's some divergence somewhere in your commit history that makes the simple gh checkout not work. I don't see any reason why that divergence is going to cause any issues. There's no conflicts. So I think we can just ignore it and merging this will work fine.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Fix bugs caused by Same-Origin Policy
Other information