minBidCacheTTL better memory optimization

[andyblackwell]

Type of issue

feature request

Description

currently minBidCacheTTL is applied at the auction level, so if you get a single bid with a long TTL, like an hour, then all the bids in the auction stay around for the full hour

Prebid.js/src/auctionManager.js

Lines 43 to 48 in 4577159

	const _auctions = ttlCollection({
	startTime: (au) => au.end.then(() => au.getAuctionEnd()),
	ttl: (au) => minCacheTTL == null ? null : au.end.then(() => {
	return Math.max(minCacheTTL, ...au.getBidsReceived().map(getTTL)) * 1000
	}),
	});

any reason we couldn't remove bids as they expire directly, in the auction object?

Prebid.js/src/auction.js

Line 156 in 4577159

let _bidsReceived = [];

could leave the auction-level removal as well, as that also frees up memory from all the other stored info in an auction like: requests, nobids, non bids, winning bids, etc

Other information

#10308

[patmmccann]

@andyblackwell great Idea! Does aditude plan to submit the fix?

[patmmccann]

Talked about this, we think a behavior change would likely not break anyone and we likely do not need additional configuration for this behavior. It seems to be a welcomed change.

[fowler446]

@patmmccann How about this ^