Core: introduce new eventHistoryTTL and minBidCacheTTL settings to control memory usage
#10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all, I am finishing up a couple high priority projects on my side so will not be able to get to this review until next week. Just wanted to give you a heads up. |
|
agreed to rename:
|
patmmccann
requested review from
jlquaccia and
mmoschovas
and removed request for
robertrmartinez and
Fawke
patmmccann
added
the
needs 2nd review
dgirardi
changed the title
eventHistoryTTL and preserveBidCache settings to control memory usageeventHistoryTTL and minBidCacheTTL settings to control memory usage
mmoschovas
approved these changes
Aug 30, 2023
ChrisHuie
added
needs 2nd review
patmmccann
approved these changes
Sep 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This introduces two new settings:
eventHistoryTTLis the time, in seconds, that events should be kept available throughpbjs.getEvents()after they are emitted;minBidCacheTTLis the minimum time, in seconds, that auctions (and related objects such as bids) should be kept available forpbjs.getAllWinningBids,pbjs.getNoBids, and related methods. If set, auctions are dropped after all the bids they contain expired, or afterminBidCacheTTLseconds have passed since they ended, whichever comes last.Other information
Closes #10189
Closes #10230