You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Twist, shine, tagoras, and kueez should all make use of vidazoo utilities for improved code maintainability
Cc @uditalias
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/twistDigitalBidAdapter.js
has 18 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 30 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 19 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 45 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 13 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 31 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 73 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 14 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 25 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 15 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js
has 10 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js
has 14 duplicated lines withmodules/twistDigitalBidAdapter.js
modules/tagorasBidAdapter.js
has 15 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js
has 31 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js
has 31 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js
has 31 duplicated lines withmodules/twistDigitalBidAdapter.js
modules/tagorasBidAdapter.js
has 40 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js
has 9 duplicated lines withmodules/twistDigitalBidAdapter.js
modules/tagorasBidAdapter.js
has 61 duplicated lines withmodules/twistDigitalBidAdapter.js
modules/shinezRtbBidAdapter.js
has 19 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
modules/shinezRtbBidAdapter.js
has 92 duplicated lines withmodules/twistDigitalBidAdapter.js
modules/kueezRtbBidAdapter.js
has 32 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Originally posted by @github-actions[bot] in #11821 (comment)
The text was updated successfully, but these errors were encountered: