New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vidazoo utils #10

Closed

uditalias wants to merge 8 commits into master from use_vidazoo_utils

+191 −1,748

uditalias commented Jun 27, 2024

THIS IS JUST A TEST PR - DO NOT MERGE IT

Type of change

Refactoring (no functional changes, no api changes)

Description of change

Refactoring ShinezRTB, Tagoras, TwistDigital, KueezRTB bid adapters to use the shared vidazooUtils in order to remove code duplications.

Other information

uditalias added 2 commits

June 27, 2024 11:21


          vidazooUtils - single request configurations

7ca2114


          fix: shines rtb adapter use vidazoo bidder utils

93920be

github-actions bot commented Jun 27, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/twistDigitalBidAdapter.js has 18 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 30 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 18 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 45 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 13 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 73 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 14 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 25 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 10 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 40 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 32 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/illuminBidAdapter.js has 13 duplicated lines with libraries/vidazooUtils/bidderUtils.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          fix: added vidazoo utils to illimin adapter

github-actions bot commented Jun 27, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/twistDigitalBidAdapter.js has 18 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 30 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 18 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 45 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 13 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 73 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 14 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 25 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 10 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 40 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 32 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/illuminBidAdapter.js has 13 duplicated lines with modules/twistDigitalBidAdapter.js
modules/illuminBidAdapter.js has 20 duplicated lines with modules/tagorasBidAdapter.js
modules/illuminBidAdapter.js has 86 duplicated lines with modules/tagorasBidAdapter.js
modules/illuminBidAdapter.js has 84 duplicated lines with modules/tagorasBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          fix: illumin bid adapter using vidazooUtils

b4dc2d8

github-actions bot commented Jun 27, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/twistDigitalBidAdapter.js has 18 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 30 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 18 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 45 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 13 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 73 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 14 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 25 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/twistDigitalBidAdapter.js has 10 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 14 duplicated lines with modules/twistDigitalBidAdapter.js
modules/tagorasBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with modules/twistDigitalBidAdapter.js
modules/tagorasBidAdapter.js has 40 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 9 duplicated lines with modules/twistDigitalBidAdapter.js
modules/tagorasBidAdapter.js has 61 duplicated lines with modules/twistDigitalBidAdapter.js
modules/kueezRtbBidAdapter.js has 32 duplicated lines with libraries/vidazooUtils/bidderUtils.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          fix: twistDigital adapter use vidazooUtils

cd1fdec

github-actions bot commented Jun 27, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/tagorasBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 26 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 9 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/tagorasBidAdapter.js has 10 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 32 duplicated lines with libraries/vidazooUtils/bidderUtils.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          fix: tagoras adapter use vidazooUtils

2a884ee

github-actions bot commented Jun 27, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/kueezRtbBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 26 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 31 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 9 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 15 duplicated lines with libraries/vidazooUtils/bidderUtils.js
modules/kueezRtbBidAdapter.js has 10 duplicated lines with libraries/vidazooUtils/bidderUtils.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          fix: kueezRtb adapter use vidazooUtils

eae9c67

patmmccann reviewed

View reviewed changes

libraries/vidazooUtils/bidderUtils.js Outdated Show resolved Hide resolved


          fix: removed parrable and digitrust id systems

de4b5ff

uditalias closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet