Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-side adapter code should not be required for server-side bidders #6388

Closed
spormeon opened this issue Mar 5, 2021 · 15 comments
Closed
Assignees

Comments

@spormeon
Copy link

spormeon commented Mar 5, 2021

I just updated to 4.29.0 from the download page UI and I don't think "prebid server" is being included in the download? client side bidders work ok, but nothing/ zip for "auction"

DevTools_-_ads_vsvl_co_uk_pub000020_scripts_AMPTEST4_29_0_html_and_Download_Prebid_js_for_Header_Bidding

@bretg
Copy link
Collaborator

bretg commented Mar 5, 2021

@spormeon - download of the pbsBidAdapter works for me.

search for a string in your package known to be within an adapter like "Incorrect or unavailable prebid server default vendor option"

What's the last version you were on? There've been a few changes in the pbsBidAdapter but nothing that should be backwards compatibility breaking. There is one bug in aliases that might affect behavior - see #6336

@spormeon
Copy link
Author

spormeon commented Mar 5, 2021

i was on 4.20 before ( my "live" instances are on this), I tried 4.28 as well, and seeing same result, its throwing a big chunk of warnings, its exactly the same setup as on "live" instances:

DevTools_-_ads_vsvl_co_uk_pub000020_scripts_AMPTEST4_29_0_html

@spormeon
Copy link
Author

spormeon commented Mar 5, 2021

hang on, have you now got to also include the actual adapters of each of the bidders?

@bretg
Copy link
Collaborator

bretg commented Mar 5, 2021

I've seen this message recently. It means your PBJS package doesn't have these bidders in them. Please verify your download/build of the package worked properly.

@spormeon
Copy link
Author

spormeon commented Mar 5, 2021

i'm only adding the adapters of the bidders that are "client" side, as before when using prebid server you didn't have to included the adapters of the prebid server bidders

@bretg
Copy link
Collaborator

bretg commented Mar 5, 2021

before when using prebid server you didn't have to included the adapters of the prebid server bidders

I thought it's been that way forever, which is why I recently opened the issue Remove requirement for client-side adapter to run server-side

@ChrisHuie, please hunt down what changed here?

Without the adapter code, PBJS doesn't know the mediatypes, permanent aliases, or GVL ID.

@bretg bretg changed the title is prebid server actually being included in 4.29.0 download? client-side adapter code should not be required for server-side bidders Mar 5, 2021
@spormeon
Copy link
Author

spormeon commented Mar 5, 2021

if i build with the server side bidders adapters included, it works. I've built without the s2s adapters being included for months back and it worked fine. To keep the file size as small as possible, now I have to "bloat" it back up again.

@ChrisHuie
Copy link
Collaborator

I think I have narrowed this down to the 4.24 release in adding multiple prebid server support #5992

@nerra0pos
Copy link

nerra0pos commented Mar 11, 2021

Just to clarify for a newby: Is it required to add the vendor adapters in addition to the "Prebid Server" module for the ones that we only request bids via S2S or not? We always added them, but now I read here it's not. Confusing.

@bretg
Copy link
Collaborator

bretg commented Mar 11, 2021

@terrapop - the goal is that client-side code should not be required to run an adapter server-side. Currently it is.

@nerra0pos
Copy link

Thank you for the clarification @bretg, so we're doing it correctly then.

@bretg
Copy link
Collaborator

bretg commented Mar 18, 2021

We discussed in PBJS meeting yesterday -- @snapwich is going to take a look at webpack to see if there's a way to surface just the aliases, mediatypes, and gvl IDs when an adapter is server-side

@bretg bretg assigned snapwich and unassigned ChrisHuie Mar 18, 2021
@gglas
Copy link

gglas commented Apr 12, 2021

@snapwich were you able to take a look at this? I will also add to this week's PMC.

@snapwich
Copy link
Collaborator

snapwich commented Apr 12, 2021

@gglas i did some investigation and commented in #6361 (comment)

I think this ticket is probably a duplicate?

@ChrisHuie
Copy link
Collaborator

closing as duplicate of #6361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants