Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid Core: Restore use of server-side adapter without client-side adapter #7711

Closed
wants to merge 4 commits into from

Conversation

jorgeluisrocha
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Fixes a bug that requires client-side adapter codes to be imported for server-side bidding. This obviates the need to import client-side adapter specifications. Additionally, this resolves the regression introduced by the original version of this PR found in #7662.

Other information

Issue: #6361
Issue: #6388

Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeluisrocha Looking at the test coverage, not a single test goes through your changes:

image

Can you add at least one test for the changes you did?

@FilipStamenkovic FilipStamenkovic added bugfix needs 2nd review Core module updates require two approvals from the core team needs unit tests labels Nov 16, 2021
@ChrisHuie ChrisHuie requested review from ChrisHuie and ncolletti and removed request for ChrisHuie November 24, 2021 16:24
@ChrisHuie ChrisHuie removed the request for review from ncolletti November 29, 2021 10:46
@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@ChrisHuie
Copy link
Collaborator

@jorgeluisrocha following up on this pr. Are you still working on this pr to add a little test coverage?

@stale stale bot removed the stale label Jan 25, 2022
@ChrisHuie ChrisHuie self-requested a review January 25, 2022 16:24
@ChrisHuie ChrisHuie self-assigned this Jan 25, 2022
@FilipStamenkovic FilipStamenkovic removed their assignment Feb 7, 2022
@patmmccann
Copy link
Collaborator

@karimMourra can you weigh in here? this seems stalled

@karimMourra
Copy link
Collaborator

Hi @patmmccann , Jorge will add unit tests to this PR when he has enough bandwidth

@ChrisHuie
Copy link
Collaborator

@karimMourra @jorgeluisrocha following up on this pr. Is it okay if I close this pr for now and it is just reopened when bandwidth provides

@bretg
Copy link
Collaborator

bretg commented Jun 30, 2022

This PR is related to issue #6361

For the record, client-side bid adapters defines 4 things that could be important to server behavior:

  1. MediaTypes
  2. Aliases
  3. GVLID
  4. transformBidParams

#1-3 are ok -- either they can be defined in s2sConfig as needed or they're also defined server-side.

A few bidAdapters do however, require transformBidParams() Those ones may not work well if the client-side adapter is not present.

@dgirardi
Copy link
Collaborator

dgirardi commented Sep 7, 2022

This was incidentally fixed in #8357; just verified that no client side adapters are needed now for interfacing with Server.

@dgirardi dgirardi closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CORE HIGH IMPACT needs unit tests needs update needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants