Adman Adapter: add transactionID #10078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add consnet to sync url
fix import
lint fix
lint fix
check consent object data availability
patmmccann
reviewed
Jun 8, 2023
modules/admanBidAdapter.js
Outdated
| @@ -109,6 +109,10 @@ export const spec = { | |||
| bidFloor: getBidFloor(bid) | |||
| } | |||
|
|
|||
| if (bid.transactionID) { | |||
| placement.transactionID = bid.transactionID; | |||
There was a problem hiding this comment.
how do you plan to use this identifier? if you pass it to dsps, put it in imp.ext.tid
There was a problem hiding this comment.
yes, we pass it to dsps. did you mean to put it like that?
There was a problem hiding this comment.
as I understand, transactionId should be correct, not ID
|
thanks! please cover with a test |
done |
patmmccann
approved these changes
Jun 23, 2023
github-ishara-chan-tung
pushed a commit
to ebuzzing/Prebid.js
that referenced
this pull request
Jul 12, 2023
* Add Adman bid adapter * Add supportedMediaTypes property * Update ADman Media bidder adapter * Remove console.log * Fix typo * revert package-json.lock * Delete package-lock.json * back to original package-lock.json * catch pbjs error * catch pbjs error * catch pbjs error * log * remove eu url * remove eu url * remove eu url * remove eu url * remove eu url * Update admanBidAdapter.js add consnet to sync url * Update admanBidAdapter.js fix import * Update admanBidAdapter.js lint fix * Update admanBidAdapter.js lint fix * Update admanBidAdapter.js check consent object data availability * сompatible with prebid v5 * add Lotame Panorama ID * update getUserSyncs * fix * fix tests * remove package-lock.json * update sync url * update test * add idx (UserID Module) * update tests * remove traffic param * handle transactionID param * send transactionID param in imp.ext * rename transactionID to transactionId * update tests --------- Co-authored-by: minoru katogi <[email protected]> Co-authored-by: minoru katogi <[email protected]> Co-authored-by: ADman Media <[email protected]> Co-authored-by: SmartyAdman <[email protected]> Co-authored-by: SmartyAdman <>
musikele
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Add Adman bid adapter * Add supportedMediaTypes property * Update ADman Media bidder adapter * Remove console.log * Fix typo * revert package-json.lock * Delete package-lock.json * back to original package-lock.json * catch pbjs error * catch pbjs error * catch pbjs error * log * remove eu url * remove eu url * remove eu url * remove eu url * remove eu url * Update admanBidAdapter.js add consnet to sync url * Update admanBidAdapter.js fix import * Update admanBidAdapter.js lint fix * Update admanBidAdapter.js lint fix * Update admanBidAdapter.js check consent object data availability * сompatible with prebid v5 * add Lotame Panorama ID * update getUserSyncs * fix * fix tests * remove package-lock.json * update sync url * update test * add idx (UserID Module) * update tests * remove traffic param * handle transactionID param * send transactionID param in imp.ext * rename transactionID to transactionId * update tests --------- Co-authored-by: minoru katogi <[email protected]> Co-authored-by: minoru katogi <[email protected]> Co-authored-by: ADman Media <[email protected]> Co-authored-by: SmartyAdman <[email protected]> Co-authored-by: SmartyAdman <>
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Add Adman bid adapter * Add supportedMediaTypes property * Update ADman Media bidder adapter * Remove console.log * Fix typo * revert package-json.lock * Delete package-lock.json * back to original package-lock.json * catch pbjs error * catch pbjs error * catch pbjs error * log * remove eu url * remove eu url * remove eu url * remove eu url * remove eu url * Update admanBidAdapter.js add consnet to sync url * Update admanBidAdapter.js fix import * Update admanBidAdapter.js lint fix * Update admanBidAdapter.js lint fix * Update admanBidAdapter.js check consent object data availability * сompatible with prebid v5 * add Lotame Panorama ID * update getUserSyncs * fix * fix tests * remove package-lock.json * update sync url * update test * add idx (UserID Module) * update tests * remove traffic param * handle transactionID param * send transactionID param in imp.ext * rename transactionID to transactionId * update tests --------- Co-authored-by: minoru katogi <[email protected]> Co-authored-by: minoru katogi <[email protected]> Co-authored-by: ADman Media <[email protected]> Co-authored-by: SmartyAdman <[email protected]> Co-authored-by: SmartyAdman <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information