Oxxion Rtd Module: add bid filtering #10100
Conversation
| @@ -23,14 +23,16 @@ Then add the oxxion Rtd module to your prebid configuration : | |||
| pbjs.setConfig( | |||
| ... | |||
| realTimeData: { | |||
| auctionDelay: 200, | |||
| auctionDelay: 300, | |||
There was a problem hiding this comment.
You meant to add the new use case in the description ?
There was a problem hiding this comment.
you write rtbModule instead of rtdModule
There was a problem hiding this comment.
Thanks, I hadn't seen it. It's fixed.
modules/oxxionRtdProvider.js
Outdated
| @@ -1,34 +1,71 @@ | |||
| import { submodule } from '../src/hook.js' | |||
| import { deepAccess, logInfo } from '../src/utils.js' | |||
| import { deepAccess, logInfo, logError } from '../src/utils.js' | |||
| import MD5 from 'crypto-js/md5.js'; | |||
There was a problem hiding this comment.
why not use something supported already?
There was a problem hiding this comment.
like this?
Line 1330 in a7f5cfb
There was a problem hiding this comment.
I need to use a hash lib which is supported in various languages, at least python and golang. However if that's an issue I can remove it as it's not yet something needed in my payload, it's for future use.
There was a problem hiding this comment.
We just don't love the include, isnt sha supported in the browser? I forget. md5 is a rather large build side include I believe.
There was a problem hiding this comment.
https://github.com/mbaersch/cyrb53-hasher is in python; fairly simple to implement in go just asking chatgpt to translate our js function to go
There was a problem hiding this comment.
I understand the include issue. I've removed the hash string side as it's not needed yet, and when I'll need to implement it back I'll switch to cyrb53
There was a problem hiding this comment.
Here's an alternative we use at raptive https://caniuse.com/?search=digest ; it has wide support for sha-1 and sha-256
There was a problem hiding this comment.
just like I said, I removed it for now as it's not needed yet.
matthieularere-msq
changed the title
* oxxion Filtering * fix test while video is activated * fix init * add details * fix typo * remove md5
* oxxion Filtering * fix test while video is activated * fix init * add details * fix typo * remove md5
* oxxion Filtering * fix test while video is activated * fix init * add details * fix typo * remove md5
Type of change
Description of change
Add a bidder filtering functionnality.