Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vox Bid Addapter: add schain, floors, userid support #10109

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

hybrid-ai
Copy link
Contributor

@hybrid-ai hybrid-ai commented Jun 17, 2023

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@hybrid-ai
Copy link
Contributor Author

@Fawke can you please check PR?

@Fawke
Copy link
Contributor

Fawke commented Jul 6, 2023

@hybrid-ai Looks good!

Can you also please update the docs on prebid.org to say now you support Floors module and User Id? Holding off on merging till then.

@hybrid-ai
Copy link
Contributor Author

@Fawke Thank you!
PR on changes in docs is ready
prebid/prebid.github.io#4714
But i dont know when it will be merged)

@Fawke Fawke merged commit 7cf0274 into prebid:master Jul 10, 2023
2 checks passed
github-ishara-chan-tung pushed a commit to ebuzzing/Prebid.js that referenced this pull request Jul 12, 2023
* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support

* vox bid adapter: add schain, floors, userid support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants