Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vidazoo Bid Adapter: support for multiple bids on single request #10110

Merged
merged 45 commits into from
Jun 28, 2023

Conversation

saar120
Copy link
Contributor

@saar120 saar120 commented Jun 18, 2023

Type of change

  • [X ] Feature

Description of change

Added support for sending multiple banner bids to the server on a single request.


uditalias and others added 30 commits March 19, 2020 14:46
added tests
@saar120
Copy link
Contributor Author

saar120 commented Jun 28, 2023

@ChrisHuie @Rothalack
Hey,
Anything needs to be done to merge this?

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing. I was planning to get this out in time for the normal thursday release, but it looks like we released on tuesday this week. So this should be out next week unless there's another release tomorrow.

@Rothalack Rothalack merged commit dd34342 into prebid:master Jun 28, 2023
2 checks passed
github-ishara-chan-tung pushed a commit to ebuzzing/Prebid.js that referenced this pull request Jul 12, 2023
…bid#10110)

* feat(module): multi size request

* fix getUserSyncs
added tests

* update(module): package-lock.json from master

* feat(module): VidazooBidAdapter - send top query params to server

* multi poc

* feat: added support for single request.

* feat: change to bids.

* change to if else

* Fixed test

---------

Co-authored-by: Udi Talias <[email protected]>
Co-authored-by: roman <[email protected]>
musikele pushed a commit to rubicon-project/Prebid.js that referenced this pull request Aug 28, 2023
…bid#10110)

* feat(module): multi size request

* fix getUserSyncs
added tests

* update(module): package-lock.json from master

* feat(module): VidazooBidAdapter - send top query params to server

* multi poc

* feat: added support for single request.

* feat: change to bids.

* change to if else

* Fixed test

---------

Co-authored-by: Udi Talias <[email protected]>
Co-authored-by: roman <[email protected]>
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
…bid#10110)

* feat(module): multi size request

* fix getUserSyncs
added tests

* update(module): package-lock.json from master

* feat(module): VidazooBidAdapter - send top query params to server

* multi poc

* feat: added support for single request.

* feat: change to bids.

* change to if else

* Fixed test

---------

Co-authored-by: Udi Talias <[email protected]>
Co-authored-by: roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants