Devcontainer: fix "Cannot start ChromeHeadless" error when running tests #10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Jun 23, 2023
github-ishara-chan-tung
pushed a commit
to ebuzzing/Prebid.js
that referenced
this pull request
Jul 12, 2023
musikele
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Aug 28, 2023
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hacky fix to allow running the test suite in devcontainer.
karma.conf.maker.js uses is-docker npm plugin to add the
--no-sandboxchrome flag when in docker, but the plugin does not work in devcontainers.The proposed simple fix is to create
/.dockerenvfor now, one of the things is-docker looks for.Adding
"securityOpt": ["seccomp=unconfined"]to devcontainer would also work by raising its privileges so the flag isn't needed, but is less secure.Eventually the test in karma.conf.maker.js should be updated to use something else, requires further discussion to cover all the previous use cases.
Other information
Resolves #10066