A1Media RTD module : initial release #10141

Sagoru · 2023-06-23T11:09:24Z

Type of change

Feature

Description of change

Add A1Media RTB provider

patmmccann · 2023-06-23T11:16:09Z

modules/a1MediaRtdProvider.js

+    const day = `0${d.getDate()}`.slice(-2);
+    const todaysDate = `${d.getFullYear()}${month}${day}`;
+
+    const scriptUrl = `${SCRIPT_URL}/${todaysDate}/${tagname}.min.js`;


Can you add some discussion of why you need external script loaded to return segments to your documentation? Is there a reason you cannot lock this script to a version instead of this date stuff?

The reason for needing an external script is not just to acquire data from the current page, but also to analyze accumulated data periodically. Instead of using a version, the script is loaded based on the date for a specific reason. The A1Media script has many customizable elements for the deployed site. Therefore, there is an issue where the script needs to be changed immediately upon request from the site. By loading the script based on the date, it ensures that the script is refreshed within a maximum of one day.

Please add this to your documentation

We added this to markdown file and prebid/prebid.github.io#4672 too

Thanks! Publishers generally prefer non-dynamic scripts so you don't break them with changes. We'll have to review this requested exception in committee.

This architecture, where each publisher has a date and pub specific script is unique. Perhaps it would be best to just not link to it from the project at all and take the endpoint as configuration.

Ok - sorry- I'll admit I thought you guys were a bid adapter at first. An RTD module is more permissive and nuanced. That rule states:

A Real-Time Data module may load external code if it requires publisher registration and there’s a prominent disclosure on the module documentation. The idea is that a publisher will not include the module if they don’t approve of the external code, and since they’ve registered for the service, they must approve. The text of the disclosure may differ if the vendor allows Prebid to do regular reviews of a strictly versioned proprietary library.

However, I don't understand what benefit you gain by putting the date in the URL. We will discuss it again internally. The proposed documented disclosure message was way too complicated. If we allow RTD modules to break this rule than publishers should not have to understand the date nuance. If anything, such a disclosure should say something simple like:

This module loads unverified external code that could change without warning.

As advised, we changed architecture to load external script to non-dynamic.
It just loads the script using the name passed from configuration.

patmmccann · 2023-06-23T11:17:43Z

modules/a1MediaRtdProvider.js

+  const a1gid = getStorageData(A1_AUD_KEY);
+  const a1Ortb2 = {
+    user: {
+      buyeruid: a1gid,


This is the wrong place I'm sure; can you add some detail on this id and perhaps we can find the right place.

It is a 1st party id that assigned to users by A1Media for the purpose of analysis and targeting.It is a 1st party user id. If you suggest the right place, we consider update that and user.ext.a1tg(below issue).

Please see the https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/2.x_official_extensions/eids.md spec.

We moved from user.buyeruid to user.ext.eids

patmmccann · 2023-06-23T11:19:13Z

modules/a1MediaRtdProvider.js

+      buyeruid: a1gid,
+      ext: {
+        a1tg: a1seg
+      }


Also appears incorrect; why not use user.data object and register a segtax? Otherwise, use user.ext.data

We moved from user.ext.a1tg to user.data

If you're going to use user.data, please reserve a segtax id with a pr to segtax.md on iabtl GitHub and populate it in this object as well

We registered segtax ( InteractiveAdvertisingBureau/openrtb#136 )
and added segtax id

patmmccann · 2023-06-23T11:22:10Z

test/spec/modules/a1MediaRtdProvider_spec.js

+        expect(subModuleObj.init(configWithParams)).to.be.true;
+        expect(window.linkback.l).to.be.true;
+        expect(loadExternalScript.called).to.be.true;
+        expect(loadExternalScript.args[0][0]).to.deep.equal('https://linkback.contentsfeed.com/src/20230610/lb4test.min.js');


updated comparing tag url.

patmmccann · 2023-07-10T17:54:40Z

modules/.submodules.json

@@ -77,7 +77,8 @@
      "sirdataRtdProvider",
      "timeoutRtdProvider",
      "weboramaRtdProvider", 
-      "zeusPrimeRtdProvider"
+      "zeusPrimeRtdProvider",
+      "a1MediaRtdProvider"


these are alphabetical

We fixed it to alphabetical

patmmccann · 2023-07-10T17:55:38Z

modules/a1MediaRtdProvider.js

+  const a1gid = getStorageData(A1_AUD_KEY);
+  const a1Ortb2 = {
+    user: {
+      buyeruid: a1gid,


Please see the https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/2.x_official_extensions/eids.md spec.

- add reason for load external script to Documentation - fix 1st party id and segment place - update rtdModule by alphabetical

ChangsikChoi · 2023-07-12T07:43:48Z

We fixed for requested changes.
Please tell me if there is something more to improve.

thank you

test/spec/modules/a1MediaRtdProvider_spec.js

- add segtax to user.data

* Create A1Media RTD Submodule * update description * add import expect property from chai for test * fix fake timestamp for test * Fix for Requested Changes - add reason for load external script to Documentation - fix 1st party id and segment place - update rtdModule by alphabetical * update load script to non-dynamic - add segtax to user.data --------- Co-authored-by: ChangsikChoi <>

ChangsikChoi and others added 2 commits June 16, 2023 14:17

Create A1Media RTD Submodule

463838f

update description

0857d65

patmmccann changed the title ~~A1Media RTB module : initial release~~ A1Media RTD module : initial release Jun 23, 2023

Sagoru mentioned this pull request Jun 23, 2023

New RTD Provider : A1Media prebid/prebid.github.io#4672

Merged

2 tasks

patmmccann reviewed Jun 23, 2023

View reviewed changes

ChangsikChoi added 2 commits June 24, 2023 10:23

add import expect property from chai for test

ea93547

fix fake timestamp for test

e57bdd6

Sagoru requested a review from patmmccann July 3, 2023 01:33

ChrisHuie assigned patmmccann Jul 6, 2023

ChrisHuie added the feature label Jul 6, 2023

patmmccann requested changes Jul 10, 2023

View reviewed changes

Fix for Requested Changes

27a9fcf

- add reason for load external script to Documentation - fix 1st party id and segment place - update rtdModule by alphabetical

patmmccann reviewed Jul 12, 2023

View reviewed changes

test/spec/modules/a1MediaRtdProvider_spec.js Show resolved Hide resolved

update load script to non-dynamic

92ce993

- add segtax to user.data

Sagoru requested a review from patmmccann July 17, 2023 01:43

patmmccann approved these changes Jul 19, 2023

View reviewed changes

patmmccann merged commit 7759968 into prebid:master Jul 19, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A1Media RTD module : initial release #10141

A1Media RTD module : initial release #10141

Sagoru commented Jun 23, 2023 •

edited

Loading

patmmccann Jun 23, 2023 •

edited

Loading

Sagoru Jun 29, 2023

patmmccann Jul 10, 2023

ChangsikChoi Jul 12, 2023

patmmccann Jul 12, 2023 •

edited

Loading

bretg Jul 12, 2023

ChangsikChoi Jul 14, 2023

patmmccann Jun 23, 2023

Sagoru Jun 29, 2023 •

edited

Loading

patmmccann Jul 10, 2023

ChangsikChoi Jul 12, 2023 •

edited

Loading

patmmccann Jun 23, 2023

ChangsikChoi Jul 12, 2023 •

edited

Loading

patmmccann Jul 12, 2023

ChangsikChoi Jul 14, 2023

patmmccann Jun 23, 2023

Sagoru Jul 3, 2023

patmmccann Jul 10, 2023

ChangsikChoi Jul 12, 2023

patmmccann Jul 10, 2023

ChangsikChoi commented Jul 12, 2023

A1Media RTD module : initial release #10141

A1Media RTD module : initial release #10141

Conversation

Sagoru commented Jun 23, 2023 • edited Loading

Type of change

Description of change

patmmccann Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patmmccann Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sagoru Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChangsikChoi Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChangsikChoi Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChangsikChoi commented Jul 12, 2023

Sagoru commented Jun 23, 2023 •

edited

Loading

patmmccann Jun 23, 2023 •

edited

Loading

patmmccann Jul 12, 2023 •

edited

Loading

Sagoru Jun 29, 2023 •

edited

Loading

ChangsikChoi Jul 12, 2023 •

edited

Loading

ChangsikChoi Jul 12, 2023 •

edited

Loading