Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex Bid Adapter: add adServerCurrency support #10152

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Saveliev
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • added adServerCurrency support
  • fixed auction price values for nurl

@Saveliev
Copy link
Contributor Author

Saveliev commented Jul 4, 2023

/start

@ChrisHuie ChrisHuie changed the title Yandex Bid Adapter: update #3 Yandex Bid Adapter: add adServerCurrency support Jul 6, 2023
@ChrisHuie ChrisHuie requested a review from mmoschovas July 6, 2023 12:48
@ChrisHuie ChrisHuie requested review from lksharma and removed request for mmoschovas July 6, 2023 12:49
@ChrisHuie ChrisHuie assigned lksharma and unassigned mmoschovas Jul 6, 2023
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saveliev, overall the changes look good. Could you also update the unit tests to reflect these changes?

* added adServerCurrency support
* fixed auction price values for nurl
@Saveliev Saveliev force-pushed the yandex-bid-adapter-update-3 branch from 173427b to ece7a20 Compare July 13, 2023 14:09
@Saveliev
Copy link
Contributor Author

/fixed
@lksharma added unit tests for these changes. Please take a look

Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lksharma lksharma merged commit df103dd into prebid:master Jul 13, 2023
2 checks passed
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
* added adServerCurrency support
* fixed auction price values for nurl

Co-authored-by: Taras Saveliev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants