Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogury Bid Adapter: init new user sync iframe #10158

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

fermeaux
Copy link
Contributor

@fermeaux fermeaux commented Jun 28, 2023

Type of change

Feature

Description of change

Init user sync through iframe

Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where you changed the adapterVersion in the spec file, I would instead pass in a constant so that you only need to change the version in one location instead of three. But that's just personal preference. Otherwise, lgtm. Approved

@fermeaux
Copy link
Contributor Author

fermeaux commented Jul 7, 2023

I take into account your feedback for the next release then. Thanks for the review

@patmmccann patmmccann merged commit 874d080 into prebid:master Jul 12, 2023
2 checks passed
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants