PubMatic Bid Adapter : add GPP support #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync up prebid master to fork master
…bid-master # Conflicts: # modules/pubmaticBidAdapter.js # test/spec/modules/pubmaticBidAdapter_spec.js
Sync with prebid master
Merge pull request #5 from pm-nitin-shirsat/master
|
docs PR prebid/prebid.github.io#4691 |
patmmccann
reviewed
Jun 29, 2023
modules/pubmaticBidAdapter.js
Outdated
| // GPP Consent | ||
| if (gppConsent?.gppString && gppConsent?.applicableSections?.length) { | ||
| syncurl += '&gpp=' + encodeURIComponent(gppConsent.gppString); | ||
| syncurl += '&gpp_sid=' + encodeURIComponent(gppConsent?.applicableSections); |
There was a problem hiding this comment.
in user syncs I think you are supposed to encode as a string, not an array
There was a problem hiding this comment.
Thank you, Yes, it should encode as string, fixed it.
|
@patmmccann - As you mentioned, gpp_sid I had encoded as a string, can you please review it? Thank you! |
ChrisHuie
changed the title
|
@ChrisHuie or @patmmccann - If anything is pending from my side to merge this PR do let me know? Thanks! |
patmmccann
approved these changes
Jul 10, 2023
|
@pm-nitin-shirsat please feel free to commit to 7.54.x as well if you desire |
github-ishara-chan-tung
pushed a commit
to ebuzzing/Prebid.js
that referenced
this pull request
Jul 12, 2023
* Implement functionality for deal priority * Update test cases * kick off test manually * Added support of GPP to PubMatic adapter * gpp_sid in user syncs supposed to encode as a string, not an array * Remove extra space * Remove trailing spaces --------- Co-authored-by: Chris Huie <[email protected]>
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Implement functionality for deal priority * Update test cases * kick off test manually * Added support of GPP to PubMatic adapter * gpp_sid in user syncs supposed to encode as a string, not an array * Remove extra space * Remove trailing spaces --------- Co-authored-by: Chris Huie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
GPP support in PubMatic bid adapter
Other information