userId Module: update GAM APIs for Eids #10172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
dgirardi
approved these changes
Jul 6, 2023
dgirardi
reviewed
Jul 6, 2023
| const encryptedSignalSources = config.getConfig('userSync.encryptedSignalSources'); | ||
| if (encryptedSignalSources) { | ||
| const registerDelay = encryptedSignalSources.registerDelay || 0; | ||
| setTimeout(() => { | ||
| encryptedSignalSources['sources'] && encryptedSignalSources['sources'].forEach(({ source, encrypt, customFunc }) => { | ||
| source.forEach((src) => { | ||
| window.googletag.encryptedSignalProviders.push({ | ||
| window.googletag.secureSignalProviders.push({ | ||
| id: src, |
There was a problem hiding this comment.
I don't know how to test this - but id does not appear in the docs you linked.
There was a problem hiding this comment.
Sorry that I linked to the wrong section in the doc. Please check this link instead:
https://developers.google.com/publisher-tag/reference#googletag.securesignals.biddersignalprovider
patmmccann
approved these changes
Jul 10, 2023
github-ishara-chan-tung
pushed a commit
to ebuzzing/Prebid.js
that referenced
this pull request
Jul 12, 2023
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Google renamed its product name from encrypted signals to secure signals, and thus API function names were changed too. Though the legacy functions are still around, it outputs deprecation messages to console. So let's migrate to new function names.
Other information