Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldlove Bid Adapter: Initial Release #10175

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Conversation

PascalSalesch
Copy link
Contributor

@PascalSalesch PascalSalesch commented Jul 3, 2023

Type of change

  • New bidder adapter

Description of change

This is a bid adapter for Yieldlove. The endpoint is a Prebid Server instance.

contact email of the adapter’s maintainer: [email protected]
test parameters for validating bids:

{
  bidder: 'yieldlove',
  params: {
    pid: 34437,
    rid: 'website.com'
  }
}

Other information

bidder params documentation: prebid/prebid.github.io#4701

@ChrisHuie ChrisHuie changed the title YieldloveBidAdapter: Release Yieldlove Bid Adapter: Initial Release Jul 6, 2023
@ChrisHuie ChrisHuie requested a review from ncolletti July 6, 2023 12:35
modules/yieldloveBidAdapter.md Outdated Show resolved Hide resolved
modules/yieldloveBidAdapter.js Outdated Show resolved Hide resolved
@ncolletti
Copy link
Contributor

When testing the supplied params from your md file, your adapter's endpoint is failing to respond with status ERR_NAME_NOT_RESOLVED -- In our testing, we expect to see this return eligible bids.

@ncolletti
Copy link
Contributor

Checked back in, I'm not seeing a change. To test on your end, you can run a gulp serve and then navigate to http://localhost:9999/integrationExamples/gpt/hello_world.html and enter your bidder params from your markdown file.

@PascalSalesch
Copy link
Contributor Author

hey @ncolletti could you give it a look again? The bid server is only listening to 443

@ncolletti
Copy link
Contributor

ncolletti commented Aug 3, 2023

@PascalSalesch This looks good, we can now see how your adapter handles a no bid response. Could you set up your endpoint to return a test ad in the format your adapter expects it to for the parameters listed in the markdown file? The expectation is that users can test against this with their params to see expected behaviors. Thank you!

@PascalSalesch
Copy link
Contributor Author

Hello,

@patmmccann no we're currently not interested in usp nor gpp strings. Our market is just the EU. We might add it in the future tho

@ncolletti unfortunately this is currently stuck, as we're figuring out if we can respond with test bids without a consent string :/
The gdpr_hello_world.html page should respond with test bids. Is that OK for now?

Greetings

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ncolletti ncolletti merged commit a81323f into prebid:master Sep 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants