Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulsePoint Bid Adapter: deals support and refactoring to use ortbConverter #10177

Merged
merged 50 commits into from
Jul 10, 2023
Merged

PulsePoint Bid Adapter: deals support and refactoring to use ortbConverter #10177

merged 50 commits into from
Jul 10, 2023

Conversation

anand-venkatraman
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

PulsePoint Bid Adapter has been simplified to use ortbConverter thats available with Prebid.
And support for Deals has been added to the adapter.

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change
@ChrisHuie ChrisHuie changed the title PulsePoint Adapter: Deals support and refactoring to use ortbConverter PulsePoint Adapter: deals support and refactoring to use ortbConverter Jul 6, 2023
@ChrisHuie ChrisHuie changed the title PulsePoint Adapter: deals support and refactoring to use ortbConverter PulsePoint Bid Adapter: deals support and refactoring to use ortbConverter Jul 6, 2023
@ChrisHuie ChrisHuie requested a review from Fawke July 6, 2023 12:34
@muuki88
Copy link
Collaborator

muuki88 commented Jul 8, 2023

Docs: prebid/prebid.github.io#4705

@Fawke Fawke merged commit b735f0b into prebid:master Jul 10, 2023
2 checks passed
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
…erter (prebid#10177)

* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* Switching to ortbConverter

* updating docs

---------

Co-authored-by: Eugene Rachitskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants