topicsFpdModule: replace ad-hoc GDPR logic with transmitUfpd acitivity check; check for topics support before loading frames
#10201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity check; check for topics support before loading frames
patmmccann
approved these changes
Jul 10, 2023
patmmccann
added
the
needs 2nd review
robertrmartinez
approved these changes
Jul 18, 2023
| @@ -86,10 +90,14 @@ export function getTopicsData(name, topics, taxonomies = TAXONOMIES) { | |||
| ); | |||
| } | |||
|
|
|||
| function isTopicsSupported(doc = document) { | |||
| return 'browsingTopics' in doc && doc.featurePolicy.allowsFeature('browsing-topics') | |||
There was a problem hiding this comment.
is it guaranteed allowsFeature will always be there if browsingTopics is? So no need to safe check here?
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
…ity check; check for topics support before loading frames (prebid#10201) * topicsFpdModule: replace ad-hoc GDPR logic with `transmitUfpd` acitivity check; check for topics support before loading frames * Use `enrichUfpd` instead of `transmitUfpd`
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
userSync.topicsURLs if the browser does not support topics (closes Topics module: check support before inserting frame #10147)enrichUfpdactivity check. Note that for GDPR, this means replacing the requirement for consent on all of purposes 1, 2, 3, and 4 with just purpose 4 (after gdprEnforcement: check for purpose 4 onenrichUfpdas well astransmitUfpd#10219 is merged) and "implicit" purpose 1 (without it topics would still be retrieved but not persisted for long enough to be of use).