Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteo Bid Adapter: add onDataDeletionRequest method #10236

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

dzhang-criteo
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Comply with US Privacy data deletion requests by providing spec.onDataDeletionRequest method.

Other information

Add support of US Privacy data deletion request method.
@ChrisHuie ChrisHuie changed the title Criteo adapter: add onDataDeletionRequest method Criteo Bid Adapter: add onDataDeletionRequest method Jul 17, 2023
@ChrisHuie ChrisHuie requested a review from Rothalack July 17, 2023 18:38
@Rothalack
Copy link
Collaborator

This has been difficult to test. To be sure I understand correctly, you are supposed to be able to trigger this via a CMP right? I've attempted with Quantcast and they don't seem to have a button for it in their CMP pop up. I see they have a way to request through their website. I assume that's not the intended flow with this function. Do you have any suggestion on how to test this? I don't have any feedback on your code, it looks good.

@dzhang-criteo
Copy link
Contributor Author

If we want to properly test this we would have to call the performDeletion command on a CMP supporting it but I do not know if there are currently any CMP which support this command.

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be good then. It hasn't caused any issues with everything else functioning.

@Rothalack Rothalack merged commit c281fc7 into prebid:master Jul 24, 2023
2 checks passed
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
Add support of US Privacy data deletion request method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants