IX bid adapter: add screen resolution in device object #10246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccorbo
force-pushed
the
device_signal_PB-1864
branch
from
391b33d
to
3ce8d2d
Compare
patmmccann
reviewed
Jul 19, 2023
| * @param {object} r | ||
| * @returns object | ||
| */ | ||
| export function addDeviceInfo(r) { |
There was a problem hiding this comment.
why not do this in the global ortb2 object for all bidders picking up device?
There was a problem hiding this comment.
Thats just going to be a longer process, as I've never touched pbjs core before. Can we merge this in for now and I can work on the core change
patmmccann
previously requested changes
Jul 19, 2023
|
@ccorbo I can add this to a utils function and just come back and update here too. There would be several adapters that could utilize this that would then need to be updated. |
|
@ChrisHuie thats great, thank you |
ChrisHuie
approved these changes
Jul 20, 2023
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
Co-authored-by: Chris Corbo <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
IX Bid Adapter: Signals device.w / device.h