Native: privacyLink is now converted to ortb.privacy #10271
Conversation
|
Will there be changes needed to support the response side of things; if a bidder returns a privacyLink URL in their bid response, is there logic to handle it in the nativeOrtbResponse and convert it for the legacy response (to the |
| @@ -480,6 +480,11 @@ export function toOrtbNativeRequest(legacyNativeAssets) { | |||
| continue; | |||
| } | |||
|
|
|||
| if (key === 'privacyLink') { | |||
| ortb.privacy = 1; | |||
There was a problem hiding this comment.
If I say privacyLink: {required: false} should this still be set to 1?
There was a problem hiding this comment.
in ORTB the flag signals support and not whether the link is required, so maybe this is OK - but we should set required: false in the inverse logic?
There was a problem hiding this comment.
My takes on this
If I say privacyLink: {required: false} should this still be set to 1?
I'd say the presence of the attribute means that you'd like to set privacy to 1.
in ORTB the flag signals support and not whether the link is required, so maybe this is OK - but we should set required: false in the inverse logic?
Agree, will fix
|
I believe this also needs a change in |
src/native.js
Outdated
| @@ -696,8 +704,11 @@ export function legacyPropertiesToOrtbNative(legacyNative) { | |||
| // in general, native trackers seem to be neglected and/or broken | |||
| response.jstracker = Array.isArray(value) ? value.join('') : value; | |||
| break; | |||
| case 'privacyLink': | |||
| response.privacy = 1; | |||
There was a problem hiding this comment.
Shouldn't this value be a string of the URL that the adapters return for the old privacyLink; which I suppose should be the value variable for this particular function?
There was a problem hiding this comment.
Yeah you are definitely right ----
There was a problem hiding this comment.
Assuming we're not doing any privacyIcon work in this PR (see #10249 (comment)), I think these changes look good and should cover the different scenarios of converting the values back/forth.
* fix for privacyLink in native prebid#10249 * handle privacy link in response too * privacy link should be returned in response --------- Co-authored-by: Michele Nasti <[email protected]>
Type of change
Description of change
In legacy native, users could request
privacyLink. Current prebid ORTB implementation was not considering this value. We decided that, ifprivacyLink: { required: true }, we setortb.privacy = 1.Other information
Discussion: #10249