gptPreAuction: fix bug where adServer object are not set in case of twin ad unit #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
requested review from
musikele and
harpere
and removed request for
musikele
dgirardi
approved these changes
Aug 21, 2023
modules/gptPreAuction.js
Outdated
Comment on lines
29
to
38
| adUnitMap[matchingAdUnitCode].forEach((adUnit) => { | ||
| adUnit.ortb2Imp = adUnit.ortb2Imp || {}; | ||
| adUnit.ortb2Imp.ext = adUnit.ortb2Imp.ext || {}; | ||
| adUnit.ortb2Imp.ext.data = adUnit.ortb2Imp.ext.data || {}; | ||
|
|
||
| const context = adUnit.ortb2Imp.ext.data; | ||
| context.adserver = context.adserver || {}; | ||
| context.adserver.name = 'gam'; | ||
| context.adserver.adslot = sanitizeSlotPath(slot.getAdUnitPath()); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| adUnitMap[matchingAdUnitCode].forEach((adUnit) => { | |
| adUnit.ortb2Imp = adUnit.ortb2Imp || {}; | |
| adUnit.ortb2Imp.ext = adUnit.ortb2Imp.ext || {}; | |
| adUnit.ortb2Imp.ext.data = adUnit.ortb2Imp.ext.data || {}; | |
| const context = adUnit.ortb2Imp.ext.data; | |
| context.adserver = context.adserver || {}; | |
| context.adserver.name = 'gam'; | |
| context.adserver.adslot = sanitizeSlotPath(slot.getAdUnitPath()); | |
| }); | |
| if (matchingAdUnitCode) { | |
| const adserver = { | |
| name: 'gam', | |
| adslot: sanitizeSlotPath(slot.getAdUnitPath()) | |
| }; | |
| adUnitMap[matchingAdUnitCode].forEach((adUnit) => { | |
| deepSetValue(adUnit, 'ortb2Imp.ext.data.adserver', Object.assign({}, adUnit.ortb2Imp?.ext?.data?.adserver, adserver)); | |
| }); | |
| } |
There was a problem hiding this comment.
@dgirardi
Thanks for review and suggestion.
I can't figure out how to add import {deepSetValue} from '../src/utils.js'; to the GH suggestion
me too.
so I fixed and committed it in local machine.
dgirardi
approved these changes
Aug 22, 2023
ChrisHuie
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix bug where adServer object are not set in case of twin ad unit.