Rubicon Bid Adapter: fix saving state of single request option #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ChrisHuie
changed the title
ChrisHuie
approved these changes
Aug 9, 2023
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
…d#10332) * revert PR prebid#9050 * revert pr 9050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Reverts the logic in PR #9050
This PR introduces a regression where if user runs multiple
rubiconsetConfigsit will not save state of the singleRequest.See my comment in the PR for more details: #9050 (comment)
This PR also introduces logic to gather the current state of the
rubiconconfig at init time if for some reason prebid core had processedsetConfigsbefore modules had been loaded.Which I have not encountered as of yet, but perhaps there are use cases where prebid core is loaded, then the que block is executed, and then modules are initialized?
Or if a module is loaded dynamically later on or something.
Now the rubicon adapter will grab the current state at init time as the initial default instead of empty object.