Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent UserId module: Add support for index id #10334

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

3link
Copy link
Contributor

@3link 3link commented Aug 9, 2023

Type of change

  • Other

Description of change

This pull request adds eid mapping for the index id that now can be resolved via the LiveIntent userId module.

Other information

@3link
Copy link
Contributor Author

3link commented Aug 9, 2023

Is the eids_spec.js broken?

@patmmccann patmmccann self-assigned this Aug 9, 2023
@patmmccann patmmccann merged commit 509deaa into prebid:master Aug 9, 2023
4 checks passed
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
@robertrmartinez
Copy link
Collaborator

@3link

Hi!

I am the lead Software Engineer at Magnite for our Prebid integrations.

I was not sure the best way to reach out but had a question for you.

When we upgrade to latest prebid version we see the AJAX call to rp.liadm.com timeout every single time.

Seems the live-connect NPM library is calling it with timeout === 0 every single time.

And setting ajaxTimeout in the config params seems to not change this.

This is happening on all of our pubs who have liveIntent implemented in their prebid wrappers.

image

Wondering how this timeout is configured as it seems to be always set to 0?

@3link
Copy link
Contributor Author

3link commented Aug 30, 2023

@robertrmartinez Thank you for reaching out. This default value seems to be the problem. It looks like Prebid changed the semantics of the value 0: it used to mean "no timeout". Whereas now it is interpreted as a valid value for a timeout. We will submit a PR with a fix soon. A temporary quick-fix could be setting the disableAjaxTimeout to true.

Sorry for the inconvenience. The good news is the error you see does not have an effect on the user id resolution.

@robertrmartinez
Copy link
Collaborator

Glad to help @3link

Seems like this will be a PR into the NPM library which will require a Prebid PR in prebids package.json to bump the version as well correct?

@3link
Copy link
Contributor Author

3link commented Aug 31, 2023

@robertrmartinez

Seems like this will be a PR into the NPM library which will require a Prebid PR in prebids package.json to bump the version as well correct?

Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants