Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent Id module: Update dependency of Live Connect #10335

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

peixunzhang
Copy link
Contributor

@peixunzhang peixunzhang commented Aug 9, 2023

Update prebid dependency on LC

LiveIntent/live-connect@v5.0.0...v6.0.0

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

live-connect has a new release https://github.com/LiveIntent/live-connect/releases/tag/v6.0.0

Update prebid dependency on LC
@peixunzhang peixunzhang marked this pull request as ready for review August 9, 2023 12:51
@ChrisHuie ChrisHuie self-requested a review August 9, 2023 13:19
@ChrisHuie ChrisHuie self-assigned this Aug 9, 2023
@patmmccann patmmccann changed the title LiveIntent Update dependency of Live Connect LiveIntent Id module: Update dependency of Live Connect Aug 9, 2023
@patmmccann patmmccann merged commit df7e863 into prebid:master Aug 9, 2023
4 checks passed
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
Update prebid dependency on LC
@robertrmartinez
Copy link
Collaborator

Hi @peixunzhang

I am the lead Software Engineer at Magnite for our Prebid integrations.

I was not sure the best way to reach out but had a question for you.

When we upgrade to latest prebid version we see the AJAX call to rp.liadm.com timeout every single time.

Seems the live-connect NPM library is calling it with timeout === 0 every single time.

And setting ajaxTimeout in the config params seems to not change this.

This is happening on all of our pubs who have liveIntent implemented in their prebid wrappers.

I am thinking it may be tracked down to this bump from live-connect 5.0.0 to 6.0.0

Wanted to see if this is some setup issue on our end, or if this is expected, or if there is an issue in the NPM library.

image

@patmmccann Wondering if you have seen this, that is if you have upgraded to a version that includes this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants