Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kulturemedia bid adapter: rebrand to dxkulture #10358

Merged
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
import {
deepAccess,
deepSetValue,
isArray,
logInfo,
deepAccess,
logError,
isFn,
isNumber,
isPlainObject,
isStr,
logError,
logInfo,
logMessage
isNumber,
isArray, logMessage
} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';

const BIDDER_CODE = 'kulturemedia';
const BIDDER_CODE = 'dxkulture';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to add your old name as an alias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review. No publisher are using our old name so it should be fine. Thanks for the heads up

const DEFAULT_BID_TTL = 300;
const DEFAULT_CURRENCY = 'USD';
const DEFAULT_NET_REVENUE = true;
Expand Down Expand Up @@ -134,13 +133,13 @@ export const spec = {
}
})
} else {
logInfo('kulturemedia.interpretResponse :: no valid responses to interpret');
logInfo('dxkulture.interpretResponse :: no valid responses to interpret');
}
return bidResponses;
},

getUserSyncs: function (syncOptions, serverResponses) {
logInfo('kulturemedia.getUserSyncs', 'syncOptions', syncOptions, 'serverResponses', serverResponses);
logInfo('dxkulture.getUserSyncs', 'syncOptions', syncOptions, 'serverResponses', serverResponses);
let syncs = [];

if (!syncOptions.iframeEnabled && !syncOptions.pixelEnabled) {
Expand Down Expand Up @@ -172,7 +171,7 @@ export const spec = {
}
}
});
logInfo('kulturemedia.getUserSyncs result=%o', syncs);
logInfo('dxkulture.getUserSyncs result=%o', syncs);
return syncs;
},

Expand Down Expand Up @@ -392,7 +391,7 @@ function buildVideoRequestData(bidRequest, bidderRequest) {
videoParams.content[contentKey].every(catStr => isStr(catStr)))) {
openrtbRequest.site.content[contentKey] = videoParams.content[contentKey];
} else {
logMessage('KultureMedia bid adapter validation error: ', contentKey, ' is either not supported is OpenRTB V2.5 or value is undefined');
logMessage('DXKulture bid adapter validation error: ', contentKey, ' is either not supported is OpenRTB V2.5 or value is undefined');
}
}
}
Expand Down Expand Up @@ -424,7 +423,7 @@ function buildBannerRequestData(bidRequests, bidderRequest) {
}));

const openrtbRequest = {
id: bidderRequest.bidderRequestId,
id: bidderRequest.auctionId,
imp: impr,
site: {
domain: bidderRequest.refererInfo?.domain,
Expand All @@ -441,6 +440,7 @@ function _createBidResponse(bid) {
bid.adomain && bid.adomain.length;
const bidResponse = {
requestId: bid.impid,
bidderCode: spec.code,
cpm: bid.price,
width: bid.w,
height: bid.h,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
# Overview

```
Module Name: Kulture Media Bid Adapter
Module Name: DXKulture Bid Adapter
Module Type: Bidder Adapter
Maintainer: [email protected]
```

# Description

Module that connects to Kulture Media's demand sources.
Kulture Media bid adapter supports Banner and Video.
Module that connects to DXKulture's demand sources.
DXKulture bid adapter supports Banner and Video.


# Test Parameters
Expand All @@ -26,10 +26,11 @@ var adUnits = [
}
},
bids: [{
bidder: 'kulturemedia',
bidder: 'dxkulture',
params: {
placementId: 'test',
publisherId: 'test',
networkId: '123'
}
}]
}
Expand Down Expand Up @@ -79,11 +80,12 @@ We support the following OpenRTB params that can be specified in `mediaTypes.vid
},
bids: [
{
bidder: 'kulturemedia',
bidder: 'dxkulture',
params: {
bidfloor: 0.5,
publisherId: '12345',
placementId: '6789'
placementId: '6789',
networkId" '123'
}
}
]
Expand All @@ -105,7 +107,7 @@ var adUnits = [
}
},
bids: [{
bidder: 'kulturemedia',
bidder: 'dxkulture',
params: {
e2etest: true
}
Expand All @@ -129,7 +131,7 @@ var adUnits = [
},
bids: [
{
bidder: 'kulturemedia',
bidder: 'dxkulture',
params: {
e2etest: true
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import {expect} from 'chai';
import {spec} from 'modules/kulturemediaBidAdapter.js';
import {spec} from 'modules/dxkultureBidAdapter.js';

const BANNER_REQUEST = {
'bidderCode': 'kulturemedia',
'bidderCode': 'dxkulture',
'auctionId': 'auctionId-56a2-4f71-9098-720a68f2f708',
'bidderRequestId': 'requestId',
'bidRequest': [{
'bidder': 'kulturemedia',
'bidder': 'dxkulture',
'params': {
'placementId': 123456,
},
Expand All @@ -17,7 +17,7 @@ const BANNER_REQUEST = {
'auctionId': 'auctionId-56a2-4f71-9098-720a68f2f708'
},
{
'bidder': 'kulturemedia',
'bidder': 'dxkulture',
'params': {
'placementId': 123456,
},
Expand Down Expand Up @@ -98,7 +98,7 @@ const RESPONSE = {
}
}
],
'seat': 'kulturemedia'
'seat': 'dxkulture'
}
],
'ext': {
Expand Down Expand Up @@ -131,11 +131,11 @@ const RESPONSE = {

const DEFAULT_NETWORK_ID = 1;

describe('kulturemediaBidAdapter:', function () {
describe('dxkultureBidAdapter:', function () {
let videoBidRequest;

const VIDEO_REQUEST = {
'bidderCode': 'kulturemedia',
'bidderCode': 'dxkulture',
'auctionId': 'e158486f-8c7f-472f-94ce-b0cbfbb50ab4',
'bidderRequestId': '34feaad34lkj2',
'bids': videoBidRequest,
Expand All @@ -158,7 +158,7 @@ describe('kulturemediaBidAdapter:', function () {
playerSize: [[640, 480]],
}
},
bidder: 'kulturemedia',
bidder: 'dxkulture',
sizes: [640, 480],
bidId: '30b3efwfwe1e',
adUnitCode: 'video1',
Expand Down Expand Up @@ -192,7 +192,7 @@ describe('kulturemediaBidAdapter:', function () {
beforeEach(function () {
// Basic Valid BidRequest
this.bid = {
bidder: 'kulturemedia',
bidder: 'dxkulture',
mediaTypes: {
banner: {
sizes: [[250, 300]]
Expand Down Expand Up @@ -223,7 +223,7 @@ describe('kulturemediaBidAdapter:', function () {
context('banner validation', function () {
it('returns true when banner sizes are defined', function () {
const bid = {
bidder: 'kulturemedia',
bidder: 'dxkulture',
mediaTypes: {
banner: {
sizes: [[250, 300]]
Expand All @@ -248,7 +248,7 @@ describe('kulturemediaBidAdapter:', function () {

invalidSizes.forEach((sizes) => {
const bid = {
bidder: 'kulturemedia',
bidder: 'dxkulture',
mediaTypes: {
banner: {
sizes
Expand All @@ -269,7 +269,7 @@ describe('kulturemediaBidAdapter:', function () {
beforeEach(function () {
// Basic Valid BidRequest
this.bid = {
bidder: 'kulturemedia',
bidder: 'dxkulture',
mediaTypes: {
video: {
playerSize: [[300, 50]],
Expand Down Expand Up @@ -509,7 +509,7 @@ describe('kulturemediaBidAdapter:', function () {
price: 6.01,
adm: '<VAST></VAST>',
adomain: [
'kulturemedia.com'
'dxkulture.com'
],
w: 640,
h: 480,
Expand All @@ -530,6 +530,7 @@ describe('kulturemediaBidAdapter:', function () {
let o = {
requestId: serverResponse.seatbid[0].bid[0].impid,
ad: '<VAST></VAST>',
bidderCode: spec.code,
cpm: serverResponse.seatbid[0].bid[0].price,
creativeId: serverResponse.seatbid[0].bid[0].crid,
vastXml: serverResponse.seatbid[0].bid[0].adm,
Expand All @@ -540,7 +541,7 @@ describe('kulturemediaBidAdapter:', function () {
ttl: 300,
netRevenue: true,
meta: {
advertiserDomains: ['kulturemedia.com']
advertiserDomains: ['dxkulture.com']
}
};
expect(bidResponse[0]).to.deep.equal(o);
Expand Down