Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluct Bid Adapter: add gpid to bid requests #10361

Merged
merged 4 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/fluctBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,20 @@ export const spec = {
const page = bidderRequest.refererInfo.page;

_each(validBidRequests, (request) => {
const impExt = request.ortb2Imp?.ext;
const data = Object();

data.page = page;
data.adUnitCode = request.adUnitCode;
data.bidId = request.bidId;
data.transactionId = request.ortb2Imp?.ext?.tid;
data.user = {
eids: (request.userIdAsEids || []).filter((eid) => SUPPORTED_USER_ID_SOURCES.indexOf(eid.source) !== -1)
};

if (impExt) {
data.transactionId = impExt.tid;
data.gpid = impExt.gpid ?? impExt.data?.pbadslot ?? impExt.data?.adserver?.adslot;
}
if (bidderRequest.gdprConsent) {
deepSetValue(data, 'regs.gdpr', {
consent: bidderRequest.gdprConsent.consentString,
Expand Down
73 changes: 73 additions & 0 deletions test/spec/modules/fluctBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,79 @@ describe('fluctAdapter', function () {
expect(request.data.page).to.eql('http://example.com');
});

it('sends no transactionId by default', function () {
const request = spec.buildRequests(bidRequests, bidderRequest)[0];
expect(request.data.transactionId).to.eql(undefined);
});

it('sends ortb2Imp.ext.tid as transactionId', function () {
const request = spec.buildRequests(bidRequests.map((req) => ({
...req,
ortb2Imp: {
ext: {
tid: 'tid',
}
},
})), bidderRequest)[0];
expect(request.data.transactionId).to.eql('tid');
});

it('sends no gpid by default', function () {
const request = spec.buildRequests(bidRequests, bidderRequest)[0];
expect(request.data.gpid).to.eql(undefined);
});

it('sends ortb2Imp.ext.gpid as gpid', function () {
const request = spec.buildRequests(bidRequests.map((req) => ({
...req,
ortb2Imp: {
ext: {
gpid: 'gpid',
data: {
pbadslot: 'data-pbadslot',
adserver: {
adslot: 'data-adserver-adslot',
},
},
},
},
})), bidderRequest)[0];
expect(request.data.gpid).to.eql('gpid');
});

it('sends ortb2Imp.ext.data.pbadslot as gpid', function () {
const request = spec.buildRequests(bidRequests.map((req) => ({
...req,
ortb2Imp: {
ext: {
data: {
pbadslot: 'data-pbadslot',
adserver: {
adslot: 'data-adserver-adslot',
},
},
},
},
})), bidderRequest)[0];
expect(request.data.gpid).to.eql('data-pbadslot');
});

it('sends ortb2Imp.ext.data.adserver.adslot as gpid', function () {
const request = spec.buildRequests(bidRequests.map((req) => ({
...req,
ortb2Imp: {
ext: {
data: {
adserver: {
adslot: 'data-adserver-adslot',
},
},
},
},
})), bidderRequest)[0];
expect(request.data.gpid).to.eql('data-adserver-adslot');
});

it('includes data.user.eids = [] by default', function () {
const request = spec.buildRequests(bidRequests, bidderRequest)[0];
expect(request.data.user.eids).to.eql([]);
Expand Down