Core: improve and fix bid timeout logic #10379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Aug 23, 2023
spotxslagle
approved these changes
Sep 14, 2023
src/adapterManager.js
Outdated
| @@ -380,7 +380,7 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request | |||
| return; | |||
| } | |||
|
|
|||
| let [clientBidRequests, serverBidRequests] = bidRequests.reduce((partitions, bidRequest) => { | |||
| let [clientBidderReqs, serverBidRequests] = bidRequests.reduce((partitions, bidRequest) => { | |||
There was a problem hiding this comment.
Is there a reason we're changing this variable? I find the new name less readable. I'd prefer clientBidderRequests, personally.
src/auction.js
Outdated
| } | ||
|
|
||
| if (_auctionEnd === undefined) { | ||
| let timedOutBidders = []; | ||
| let timedOutReqs = []; |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
bidderTimeoutand the other sometimes firing afterbidderTimeout + timeoutBuffer. Since the second, when it happens, always happens too late, it was removed as redundant.Other information
Closes #10349