AIDEM Bidder Adapter: ortbConverter #10391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests
Added missing semicolons
|
FYI, video tests are failing because the pipeline runs them once with all features disabled, and the conversion library skips the video logic. To fix it, disable video-specific tests like this: you can test locally with |
ChrisHuie
requested review from
ChrisHuie
and removed request for
jsnellbaker
patmmccann
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Moved aidemBidAdapter implementation to comply with ortbConverter