Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fledgeForGpt: provide bidfloor in auction signals #10393

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Feature

Description of change

This adds two auction signals to fledge: prebid.bidfloor and prebid.bidfloorcur.

The bidfloor value is either the highest CPM that Prebid got for the slot, or (if there were no bids) the minimum required floor across all requests for the slot.

Other information

Closes #10139

@laurb9
Copy link
Contributor

laurb9 commented Sep 6, 2023

I did a small "live" test - made a bundle with fledgeForGpt and openxBidAdapter, faked an openx server response to inject some auctionSignals and intercepted runAdAuction in the page to print out the arguments. I can see the expected merged auctionSignals in the prebid debug log as well as in the runAdAuction configuration passed by GPT:

Screenshot 2023-09-05 at 6 23 24 PM

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie added the needs 2nd review Core module updates require two approvals from the core team label Sep 6, 2023
@robertrmartinez
Copy link
Collaborator

Hey all I am out starting today and will not be able to review this. Sorry I did not get to it.

@ChrisHuie ChrisHuie removed the request for review from robertrmartinez September 14, 2023 17:23
@patmmccann patmmccann mentioned this pull request Sep 14, 2023
9 tasks
@patmmccann patmmccann self-requested a review September 14, 2023 18:03
@patmmccann patmmccann self-assigned this Sep 14, 2023
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking @laurb9 's review as second, thanks!

@patmmccann patmmccann merged commit 7764e53 into prebid:master Sep 14, 2023
2 of 3 checks passed
@pm-nitin-nimbalkar
Copy link
Contributor

@patmmccann @Fawke @laurb9

Hi Guys, Am just confused with the sentence written in description section "or (if there were no bids) the minimum required floor across all requests for the slot."

If there is no contextual bids for particular fledge slot, my assumption is that bid floor value should be 0. So what is "the minimum required floor across all requests for the slot." How this is calculated. Bit confused on this.

Can you elaborate it more on this with examples ?

TIA,
Nitin

@pm-harshad-mane
Copy link
Contributor

@pm-nitin-nimbalkar , the publisher sets a floor value that is passed to all bidders in the contextual-request and bidders are required to bid higher than the floor value. if partners do not return contextual bids then in this case the floor value set by the publisher will be passed in PA.

@pm-nitin-nimbalkar
Copy link
Contributor

Got it @pm-harshad-mane . Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fledge for gpt module: add contextual win price to configs
8 participants