Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubmatic Analytics Adapter : changing the dealId default value #10394

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Pubmatic Analytics Adapter : changing the dealId default value #10394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/pubmaticAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const ERROR = 'error';
const REQUEST_ERROR = 'request-error';
const TIMEOUT_ERROR = 'timeout-error';
const EMPTY_STRING = '';
const OPEN_AUCTION_DEAL_ID = '-1';
const MEDIA_TYPE_BANNER = 'banner';
const CURRENCY_USD = 'USD';
const BID_PRECISION = 2;
Expand Down Expand Up @@ -270,7 +271,7 @@ function gatherPartnerBidsForAdUnitForLogger(adUnit, adUnitId, highestBid) {
'psz': bid.bidResponse ? (bid.bidResponse.dimensions.width + 'x' + bid.bidResponse.dimensions.height) : '0x0',
'eg': bid.bidResponse ? bid.bidResponse.bidGrossCpmUSD : 0,
'en': bid.bidResponse ? bid.bidResponse.bidPriceUSD : 0,
'di': bid.bidResponse ? (bid.bidResponse.dealId || EMPTY_STRING) : EMPTY_STRING,
'di': bid.bidResponse ? (bid.bidResponse.dealId || OPEN_AUCTION_DEAL_ID) : OPEN_AUCTION_DEAL_ID,
'dc': bid.bidResponse ? (bid.bidResponse.dealChannel || EMPTY_STRING) : EMPTY_STRING,
'l1': bid.bidResponse ? bid.clientLatencyTimeMs : 0,
'l2': 0,
Expand Down Expand Up @@ -428,6 +429,7 @@ function executeBidWonLoggerCall(auctionId, adUnitId) {
pixelURL += '&eg=' + enc(winningBid.bidResponse.bidGrossCpmUSD);
pixelURL += '&kgpv=' + enc(getValueForKgpv(winningBid, adUnitId));
pixelURL += '&piid=' + enc(winningBid.bidResponse.partnerImpId || EMPTY_STRING);
pixelURL += '&di=' + enc(winningBid?.bidResponse?.dealId || OPEN_AUCTION_DEAL_ID);

pixelURL += '&plt=' + enc(getDevicePlatform());
pixelURL += '&psz=' + enc((winningBid?.bidResponse?.dimensions?.width || '0') + 'x' +
Expand Down
10 changes: 5 additions & 5 deletions test/spec/modules/pubmaticAnalyticsAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ describe('pubmatic analytics adapter', function () {
expect(data.s[0].ps[0].psz).to.equal('640x480');
expect(data.s[0].ps[0].eg).to.equal(1.23);
expect(data.s[0].ps[0].en).to.equal(1.23);
expect(data.s[0].ps[0].di).to.equal('');
expect(data.s[0].ps[0].di).to.equal('-1');
expect(data.s[0].ps[0].dc).to.equal('');
expect(data.s[0].ps[0].l1).to.equal(3214);
expect(data.s[0].ps[0].l2).to.equal(0);
Expand Down Expand Up @@ -701,7 +701,7 @@ describe('pubmatic analytics adapter', function () {
expect(data.s[1].ps[0].psz).to.equal('0x0');
expect(data.s[1].ps[0].eg).to.equal(0);
expect(data.s[1].ps[0].en).to.equal(0);
expect(data.s[1].ps[0].di).to.equal('');
expect(data.s[1].ps[0].di).to.equal('-1');
expect(data.s[1].ps[0].dc).to.equal('');
expect(data.s[1].ps[0].mi).to.equal(undefined);
expect(data.s[1].ps[0].l1).to.equal(0);
Expand Down Expand Up @@ -739,7 +739,7 @@ describe('pubmatic analytics adapter', function () {
expect(data.s[1].ps[0].psz).to.equal('0x0');
expect(data.s[1].ps[0].eg).to.equal(0);
expect(data.s[1].ps[0].en).to.equal(0);
expect(data.s[1].ps[0].di).to.equal('');
expect(data.s[1].ps[0].di).to.equal('-1');
expect(data.s[1].ps[0].dc).to.equal('');
expect(data.s[1].ps[0].mi).to.equal(undefined);
expect(data.s[1].ps[0].l1).to.equal(0);
Expand Down Expand Up @@ -1135,7 +1135,7 @@ describe('pubmatic analytics adapter', function () {
expect(data.s[0].ps[0].psz).to.equal('640x480');
expect(data.s[0].ps[0].eg).to.equal(1.23);
expect(data.s[0].ps[0].en).to.equal(1.23);
expect(data.s[0].ps[0].di).to.equal('');
expect(data.s[0].ps[0].di).to.equal('-1');
expect(data.s[0].ps[0].dc).to.equal('');
expect(data.s[0].ps[0].l1).to.equal(3214);
expect(data.s[0].ps[0].l2).to.equal(0);
Expand Down Expand Up @@ -1254,7 +1254,7 @@ describe('pubmatic analytics adapter', function () {
expect(data.s[0].ps[0].psz).to.equal('640x480');
expect(data.s[0].ps[0].eg).to.equal(1.23);
expect(data.s[0].ps[0].en).to.equal(1.23);
expect(data.s[0].ps[0].di).to.equal('');
expect(data.s[0].ps[0].di).to.equal('-1');
expect(data.s[0].ps[0].dc).to.equal('');
expect(data.s[0].ps[0].l1).to.equal(3214);
expect(data.s[0].ps[0].l2).to.equal(0);
Expand Down