Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangle Bid Adapter : initial release #10397

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Conversation

bytedancer-1
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@ChrisHuie ChrisHuie changed the title New bidder adapter: pangle Pangle Bid Adapter : initial release Aug 28, 2023
@bretg
Copy link
Collaborator

bretg commented Aug 30, 2023

docs PR prebid/prebid.github.io#4823

@bytedancer-1
Copy link
Contributor Author

Update the same parameters, please help to see, no problem to help merge into it

@Rothalack
Copy link
Collaborator

Here's the errors thrown in the circleci build, not sure if you'd be able to see them or not.

Chrome 116.0.0.0 (Windows 10): Executed 13349 of 13345 (4 FAILED) (45.976 secs / 21.265 secs)
TOTAL: 4 FAILED, 13345 SUCCESS

  1. should accept request if placementid and appid is passed
    pangle bid adapter isBidRequestValid
    AssertionError: expected false to equal true
    at Context. (/tmp/_karma_webpack_346388/commons.js:347570:75)

  2. should return correct device type: tablet
    pangle bid adapter parseUserAgent
    TypeError: _pangleBidAdapter.spec.getDeviceType is not a function
    at Context. (/tmp/_karma_webpack_346388/commons.js:347624:47)

  3. should return correct device type: mobile
    pangle bid adapter parseUserAgent
    TypeError: _pangleBidAdapter.spec.getDeviceType is not a function
    at Context. (/tmp/_karma_webpack_346388/commons.js:347628:47)

  4. should return correct device type: desktop
    pangle bid adapter parseUserAgent
    TypeError: _pangleBidAdapter.spec.getDeviceType is not a function
    at Context. (/tmp/_karma_webpack_346388/commons.js:347632:47)

[11:12:39] 'test-all-features-disabled' errored after 2.68 min
[11:12:39] Error: Karma tests failed with exit code 1
at ChildProcess. (/home/circleci/Prebid.js/gulpfile.js:342:12)
at ChildProcess.emit (events.js:311:20)
at ChildProcess.EventEmitter.emit (domain.js:505:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
[11:12:39] 'test' errored after 3.75 min

Exited with code exit status 1

@bretg
Copy link
Collaborator

bretg commented Sep 1, 2023

@bytedancer-1 - thanks for making the parameter change. And Prebid publishers thank you as well.

Please remove the ".history/modules" directory from this PR.

@bytedancer-1
Copy link
Contributor Author

bytedancer-1 commented Sep 4, 2023

@bretg Take out the history. Look again, please. Thank you

@bytedancer-1
Copy link
Contributor Author

@Rothalack Repair completed, please help review again

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing for me.

@Rothalack Rothalack merged commit 2087aca into prebid:master Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants