Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnite Analytics Adapter:support for eventDispatcher #10399

Merged
merged 1 commit into from
Aug 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/magniteAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ const sendEvent = payload => {
...getTopLevelDetails(),
...payload
}
if (window.pbjs?.rp?.eventDispatcher) {
const analyticsEvent = new CustomEvent('beforeSendingMagniteAnalytics', { detail: event });
window.pbjs.rp.eventDispatcher.dispatchEvent(analyticsEvent);
}
ajax(
endpoint,
null,
Expand Down
34 changes: 34 additions & 0 deletions test/spec/modules/magniteAnalyticsAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1492,6 +1492,40 @@ describe('magnite analytics adapter', function () {
expect(message).to.deep.equal(expectedMessage);
});

describe('when eventDispatcher is present', () => {
beforeEach(() => {
window.pbjs = window.pbjs || {};
pbjs.rp = pbjs.rp || {};
pbjs.rp.eventDispatcher = pbjs.rp.eventDispatcher || document.createElement('fakeElem');
});

afterEach(() => {
delete pbjs.rp.eventDispatcher;
delete pbjs.rp;
});

it('should dispatch beforeSendingMagniteAnalytics if possible', () => {
pbjs.rp.eventDispatcher.addEventListener('beforeSendingMagniteAnalytics', (data) => {
data.detail.test = 'testData';
});

performStandardAuction();

expect(server.requests.length).to.equal(1);
let request = server.requests[0];

expect(request.url).to.equal('http://localhost:9999/event');

let message = JSON.parse(request.requestBody);

const AnalyticsMessageWithCustomData = {
...ANALYTICS_MESSAGE,
test: 'testData'
}
expect(message).to.deep.equal(AnalyticsMessageWithCustomData);
});
})

describe('when handling bid caching', () => {
let auctionInits, bidRequests, bidResponses, bidsWon;
beforeEach(function () {
Expand Down